Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskOrchestrationContext WaitForExternalEvent doesn't support overload without event data #338

Open
collinstevens opened this issue Aug 9, 2024 · 0 comments
Labels
Enhancement New feature or request feature-parity This feature is needed for parity with other language SDKs

Comments

@collinstevens
Copy link

unlike the in-process IDurableOrchestrationContext, the isolated TaskOrchestrationContext doesn't have a overload of WaitForExternalEvent which doesn't require event data.

the documentation shows this overload being used
https://github.com/MicrosoftDocs/azure-docs/blob/561b5b43606212719112cf3d6125af91241a6828/articles/azure-functions/durable/durable-functions-external-events.md?plain=1#L231-L245

the overloads on IDurableOrchestrationContext
https://github.com/Azure/azure-functions-durable-extension/blob/c7260c0a8b35bd35752615cae47c17db44f24798/src/WebJobs.Extensions.DurableTask/ContextInterfaces/IDurableOrchestrationContext.cs#L368-L393

more odd, the DurableTaskClient has an overload which indicates the event data may not be required for an event.

public virtual Task RaiseEventAsync(
string instanceId, string eventName, CancellationToken cancellation)
=> this.RaiseEventAsync(instanceId, eventName, null, cancellation);

@collinstevens collinstevens changed the title TaskOrchestrationContext WaitForExternalEvent doesn't support variant without event data TaskOrchestrationContext WaitForExternalEvent doesn't support overload without event data Aug 9, 2024
@lilyjma lilyjma added question The issue doesn't require a change to the product in order to be resolved. Enhancement New feature or request feature-parity This feature is needed for parity with other language SDKs and removed Needs: Triage 🔍 question The issue doesn't require a change to the product in order to be resolved. labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request feature-parity This feature is needed for parity with other language SDKs
Projects
None yet
Development

No branches or pull requests

2 participants