Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow internal artifact feed configuration in pip detector #415

Open
annaowens opened this issue Jan 30, 2023 · 1 comment
Open

Allow internal artifact feed configuration in pip detector #415

annaowens opened this issue Jan 30, 2023 · 1 comment
Assignees
@cobya
Labels
detector:pip The pip detector status:in-progress Someone is working on implementation type:bug Bug fix of existing functionality

Comments

@annaowens
Copy link
Contributor

annaowens commented Jan 30, 2023 •
edited by melotic
Loading

Today, the Pip detector automatically pulls from PyPI for latest version + dependency tree.

component-detection/docs/detectors/pip.md

Line 25 in cf622c7

For every top level component, Pip detection makes http calls to Pip in order to determine latest version available, as well as to resolve the dependency tree by parsing the `METADATA` file on a given release's `bdist_wheel` or `bdist_egg`.

We should use users' internal feeds, if configured, rather than making HTTP calls to PyPI by default.
@annaowens annaowens added status:requirements Full requirements are not yet known, so implementation should not be started detector:pip The pip detector labels Jan 30, 2023
@JamieMagee JamieMagee added type:bug Bug fix of existing functionality and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Feb 22, 2023
@melotic melotic mentioned this issue Jul 14, 2023
Closed
@cobya cobya mentioned this issue Apr 18, 2024
Open
@cobya cobya self-assigned this May 23, 2024
@cobya
Copy link
Contributor

cobya commented May 23, 2024

#1129 now has support in experimental detection to handle this using the PIP_INDEX_URL environment variable.

@cobya cobya moved this from Backlog to In review in Component Detection - Detector Improvements May 23, 2024
@cobya cobya added the status:in-progress Someone is working on implementation label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cobya cobya

Labels
detector:pip The pip detector status:in-progress Someone is working on implementation type:bug Bug fix of existing functionality
Projects
Component Detection - Detector Improvements
Status: In review
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JamieMagee @cobya @annaowens