Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Invalid URI for Shellcheck #651

Closed
mcollier opened this issue May 27, 2021 · 1 comment
Closed

[BUG] Invalid URI for Shellcheck #651

mcollier opened this issue May 27, 2021 · 1 comment
Labels
bug Something isn't working code reviews Code reviews topic

Comments

@mcollier
Copy link
Contributor

Describe the bug
The bash script suggested for the Azure DevOps pipeline validation is invalid. The inline script uses a URL for shellcheck which is no longer valid. Per the guidance at koalaman/shellcheck#1871, releases should use the downloads from the Github releases, not https://storage.googleapis.com/shellcheck.

To Reproduce

  1. Execute the script defined at https://github.com/microsoft/code-with-engineering-playbook/blob/main/docs/code-reviews/recipes/bash.md#build-validation
  2. Run shellcheck against a .sh file.
  3. Observe the following output message:
You are downloading ShellCheck from an outdated URL!

Please update to the new URL:
https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.linux.x86_64.tar.xz

For more information, see:
https://github.com/koalaman/shellcheck/issues/1871

PS: Sorry for breaking your build :(
@mcollier mcollier added bug Something isn't working code reviews Code reviews topic labels May 27, 2021
@tompaana
Copy link
Member

Fixed by #725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code reviews Code reviews topic
Projects
None yet
Development

No branches or pull requests

2 participants