Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Adaptive Card Template parsing functionality Changed after switching to 0.8-preview #3144

Closed
DavidStrickland0 opened this issue Mar 4, 2020 · 6 comments · Fixed by #3300
Closed
Assignees
Labels
customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. PR: unreviewed Status: In Progress This work item in underway. Type: Bug Something isn't working
Milestone

Comments

@DavidStrickland0
Copy link

DavidStrickland0 commented Mar 4, 2020

Not certain if this got documented anywhere been chasing it for a couple days now not so much a bug with BotFramework.Solution as it is a change with Microsoft.Bot.Builder.LanguageGeneration however given it starts out looking like a BotFrameworkSolution issue figured I'd get it documented here.

Rescently updated my project to use Microsoft.Bot.Solution 0.8 preview.

When I did most of my app broke. Namely things just weren't showing up in the Bot the same way they did before. My Intro Adaptive Card just plain wouldnt show up and other pages wheren't replacing thier content the same way they had before the upgrade.

Pre Upgrade my NewUserIntro Card Looked like this:

# NewUserIntroCard
[Activity
    Attachments = {json(NewUserIntroCardJson())}
]

post upgrade I had to change it to

# NewUserIntroCard
[Activity
    Attachments = @{json(NewUserIntroCardJson())}
]

Granted it likely should have been thatway all along and I assume its not so much because Bot.Solution changed as much as it is that includes an upgrade of Microsoft.Bot.Builder.LanguageGeneration which is where I assume the change occured. Figured it was worth noting.... Before someone else has to spend a couple days tracking back through thier app to figure it out.

@DavidStrickland0 DavidStrickland0 added Needs Triage Needs to be triaged for assignment Type: Bug Something isn't working labels Mar 4, 2020
@DavidStrickland0 DavidStrickland0 changed the title Template parsing functionality Change Template parsing functionality Changed after switching to 0.8-preview Mar 4, 2020
@DavidStrickland0 DavidStrickland0 changed the title Template parsing functionality Changed after switching to 0.8-preview Adaptive Card Template parsing functionality Changed after switching to 0.8-preview Mar 4, 2020
@DavidStrickland0
Copy link
Author

For what its worth similar change has been made to the text tokens
Pre 0.8 we had

            {
              "type": "TextBlock",
              "text": "{Origin}",
              "size": "ExtraLarge",
              "spacing": "None"
            }

Post upgrade we have to use

            {
              "type": "TextBlock",
              "text": "@{Origin}",
              "size": "ExtraLarge",
              "spacing": "None"
            }

@ryanisgrig ryanisgrig self-assigned this Mar 9, 2020
@ryanisgrig
Copy link
Collaborator

Thanks @DavidStrickland0! There's another syntax change we have to make regarding LG that I will track down and update here with a linked issue. Stay tuned.

@ryanisgrig ryanisgrig added this to the GA milestone Mar 9, 2020
@ryanisgrig ryanisgrig added Status: Committed This has been confirmed for the next release. and removed Needs Triage Needs to be triaged for assignment labels Mar 9, 2020
@ryanisgrig
Copy link
Collaborator

I don't see doc updates available yet but the new syntax will actually be using ${} instead of @{} per
microsoft/botbuilder-dotnet#3381

@darrenj
Copy link
Contributor

darrenj commented Mar 13, 2020

@ryanlengel We'll need to make this is documented as part of our known issues / upgrade steps for 1.0

@ryanisgrig
Copy link
Collaborator

ryanisgrig commented Mar 23, 2020

See the release notes for LG at https://github.com/microsoft/BotBuilder-Samples/tree/master/experimental/language-generation#48-preview for breaking changes updating to v4.8.*

I'm leaving this open to track as known issue in our docs for the next release.

@peterinnesmsft peterinnesmsft added PR: unreviewed Status: In Progress This work item in underway. and removed Status: Committed This has been confirmed for the next release. labels Apr 22, 2020
@peterinnesmsft peterinnesmsft linked a pull request Apr 23, 2020 that will close this issue
3 tasks
@peterinnesmsft peterinnesmsft added customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Apr 23, 2020
@peterinnesmsft
Copy link
Contributor

I've added to the GA release notes with a link to handling the LG breaking changes. These will be published when we officially release. You can find the changes in the PR I linked above.

Going to close this issue out since I believe this is now ultimately addressed, but feel free to reopen if you think it could be improved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. PR: unreviewed Status: In Progress This work item in underway. Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants