Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streaming] Stop using @types/node in botframework-streaming #1663

Closed
stevengum opened this issue Feb 4, 2020 · 0 comments · Fixed by #1795
Closed

[Streaming] Stop using @types/node in botframework-streaming #1663

stevengum opened this issue Feb 4, 2020 · 0 comments · Fixed by #1795
Assignees
@Zerryth
Labels
bug Indicates an unexpected problem or an unintended behavior. P2 Nice to have R8 Release 8 - March 16th, 2020
Milestone
R8

Comments

@stevengum
Copy link
Member

Versions

What package version of the SDK are you using. 4.7.1

Describe the bug

In the NamedPipeServer we have direct type dependencies on classes from the "net" module. We should use the library abstractions to avoid unclear type dependencies on Node.js builtins.

Additional context

Related to #1575

[bug]
@stevengum stevengum added P2 Nice to have R8 Release 8 - March 16th, 2020 Streaming Extensions labels Feb 4, 2020
@stevengum stevengum self-assigned this Feb 4, 2020
@stevengum stevengum removed their assignment Feb 18, 2020
This was referenced Feb 20, 2020
Closed
Closed
Closed
Merged
@Zerryth Zerryth changed the title [Streaming] Stop using @types/node in NamedPipe streaming code [Streaming] Stop using @types/node in botframework-streaming Feb 28, 2020
@johnataylor johnataylor added R9 Release 9 - May 15th, 2020 and removed R8 Release 8 - March 16th, 2020 labels Mar 3, 2020
@github-actions github-actions bot added the bug Indicates an unexpected problem or an unintended behavior. label Mar 3, 2020
@Zerryth Zerryth added enhancement and removed bug Indicates an unexpected problem or an unintended behavior. labels Mar 3, 2020
@github-actions github-actions bot added the bug Indicates an unexpected problem or an unintended behavior. label Mar 3, 2020
@Zerryth Zerryth added R8 Release 8 - March 16th, 2020 and removed R9 Release 9 - May 15th, 2020 labels Mar 4, 2020
@munozemilio munozemilio added this to the R8 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zerryth Zerryth

Labels
bug Indicates an unexpected problem or an unintended behavior. P2 Nice to have R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
R8
4 participants
@johnataylor @stevengum @Zerryth @munozemilio