Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Implement hash for App Insights session ID #1646

Closed
tomlm opened this issue Jan 30, 2020 · 3 comments
Closed

[PORT] Implement hash for App Insights session ID #1646

tomlm opened this issue Jan 30, 2020 · 3 comments

Comments

@tomlm
Copy link
Contributor

tomlm commented Jan 30, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3317

Addresses this issue reported in JS #1512

App Insights has a maximum session ID of 64 characters, but in some instances for some channels (such as reported with Teams) this may be exceeded due to conversation ID currently being used for session ID. This PR hashes the conversation ID and sets this as the session ID. It also adds an additional telemetry property to ensure we retain the original conversation ID within the telemetry.

The hashed ID is only used for Application Insights and the original conversation ID and activity are left untouched.

Changed projects

  • integration
@Stevenic
Copy link
Contributor

Needs porting to JS.

@garypretty
Copy link
Contributor

PR #1642 awaiting review.

@garypretty
Copy link
Contributor

Closing as duplicate of #1512 - the original issue was in JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants