Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

[PORT] Implement hash for App Insights session ID #247

Closed
tomlm opened this issue Jan 30, 2020 · 0 comments
Closed

[PORT] Implement hash for App Insights session ID #247

tomlm opened this issue Jan 30, 2020 · 0 comments

Comments

@tomlm
Copy link
Contributor

tomlm commented Jan 30, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3317

Addresses this issue reported in JS microsoft/botbuilder-js#1512

App Insights has a maximum session ID of 64 characters, but in some instances for some channels (such as reported with Teams) this may be exceeded due to conversation ID currently being used for session ID. This PR hashes the conversation ID and sets this as the session ID. It also adds an additional telemetry property to ensure we retain the original conversation ID within the telemetry.

The hashed ID is only used for Application Insights and the original conversation ID and activity are left untouched.

Changed projects

  • integration
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants