-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spec] Samples for Bot Builder V4 SDK #834
Comments
@vishwacsena , there are minor copy & paste error in the sample structure js folder/files description. update the .CS ref to JavaScript | - Program.js // Default program.cs |
These look great! I missed these initially because I was looking at botbuilder-dotnet/master, mostly because I can't follow instructions but just an FYI as other people may do the same |
Looks great !!! Some of the suggestions I've is:
Question: Can we integrate Adaptivecard.io Visualizer into Bot Framework Emulator or VSCode to design cards and test it how it looks in different channels? |
@yochay - Fixed. |
@vishwacsena Transcripts at root level makes sense. 👍 |
VS Code should be the preferred editor for JS bots. Most folks don't use NTVS, as cool as it is. For both .NET (core at least) and Node.js, you should have a sample on how to run from CLI. Ideally, for node.js, it would work with just I'd encourage having at least 1 or 2 TypeScript samples for Node.js as well. It's really helpful to have a sample with .tsconfig/etc. already set up to be able to go quickly. You can just ts-node in the package.json for the npm run (aka: "start": "ts-node app.ts") This assumes standalone servers for hosting the samples, but have you considered showing samples for FaaS? (Azure Functions, AWS Lambda, etc.) (I don't think this is a requirement, but worth thinking about, especially if you're doing deploy to azure samples) (FWIW, I think you can make the Node.js samples work in Azure Functions and standalone server with no code changes. I can help if needed...) |
@christopheranderson we document steps required for developers success using popular tools like VS Code as well as common Microsoft tools like VS. Most current JS samples, for example Echo-Bot work with npm install + npm start. We will take a not to make sure JS samples continue to have that functionality (they have to...) Good point regarding TS, which should be part of the deliverables to make sure anyone can run the samples using the existing scripts. The primary goal of these samples is to enable developers to experiment and learn how to build bots successfully. We want the developer to get a bot running locally as quickly as possible. Therefore we aim for a local run and test scenarios using the emulator. All samples include provisioning of resources in Azure and deployment of the bot. @christopheranderson - We will surely take you on your word to help run JS bots on Azure Functions :) |
@vishwacsena do we need to add a 'deployment' folder for resource generation and deployment scripts? |
@yochay - fixed. Also updated samples structure based on feedback. |
@vishwacsena as I read through these, should we identify which samples build on top of previous. For example, sample #3 should use sample #2 as the baseline, sample 4 should use 3 and so on... not all samples make sense to combine, but for those we believe do compose, let's identify that in advance (if we all agree to the above) |
@vishwachsena I changed the casing on the the README.MD markdown files to be lowercase. This aligns with standard norms. |
Referring to #855 Added a branch https://github.com/Microsoft/botbuilder-dotnet/tree/johtaylo/translation-sample |
Updated to move main dialog under dialogs. renamed app.js to index.js |
Please help me to find code for 19.Bot-Authentication |
samples are in BotBuilder-Samples v4 branch until merged into master and are following the guidelines outlined above |
Goals
Samples structure - C#
Samples structure - JS
README.md template
Samples repo structure, naming conventions
Samples list
Advanced topics
Additional advanced topics to consider based on feedback
Feedback welcome.
The text was updated successfully, but these errors were encountered: