Adaptive HttpRequest body does not interpret property for body field

[scheyal]

‘Body’ is taking the property string literally "@{dialog.httpbody}". It seems that Body requires a JObject. In turn, Json is throwing an exception

Example:

new Microsoft.Bot.Builder.Dialogs.Adaptive.Actions.HttpRequest()
                                    {
                                        // Set response from the http request to turn.httpResponse property in memory.
                                        ResultProperty = "dialog.httpResponse",
                                        Url = apiUrl,
                                        Method = HttpRequest.HttpMethod.POST,
                                        Body = "@{dialog.httpbody}",
                                        ResponseType = HttpRequest.ResponseTypes.None
                                    },

$exception {System.InvalidOperationException: The parent is missing.
at Newtonsoft.Json.Linq.JToken.Replace(JToken value)
at Microsoft.Bot.Builder.Dialogs.Adaptive.Actions.HttpRequest.ReplaceJTokenRecursively(DialogContext dc, JToken token)
at Microsoft.Bot.Builder.Dialogs.Adaptive.Actions.HttpRequest.BeginDialogAsync(DialogContext dc, Object options, CancellationToken cancellationToken)

[vishwacsena]

I debugged this and the core issue seems to be twofold.

Issue #1: we should consider adding headers without validation TryAddWithoutValidation so things like adding content-type does not blow up (it does with a .Add())

// Set headers
if (instanceHeaders != null)
{
    foreach (var unit in instanceHeaders)
    {
        client.DefaultRequestHeaders.TryAddWithoutValidation(
            await new TextTemplate(unit.Key).BindToData(dc.Context, dc.GetState()).ConfigureAwait(false),
            await new TextTemplate(unit.Value).BindToData(dc.Context, dc.GetState()).ConfigureAwait(false));
    }
}

Issue #2: Data binding within JArray blows up in ReplaceJTokenRecursively

new HttpRequest()
{
    Body = new JObject(
            new JProperty(
                "list",
                new JArray(
                    new JValue("@{dialog.appId1}"),
                    new JValue("@{dialog.appId2}")))),
    Url = ""
}