Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luis settings is not parsed correctly #3166

Closed
xieofxie opened this issue Dec 19, 2019 · 1 comment
Closed

luis settings is not parsed correctly #3166

xieofxie opened this issue Dec 19, 2019 · 1 comment
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior. R8 Release 8 - March 16th, 2020
Milestone

Comments

@xieofxie
Copy link
Contributor

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

What package version of the SDK are you using.

Describe the bug

Give a clear and concise description of what the bug is.

Here it uses @{}: https://github.com/microsoft/botbuilder-dotnet/blob/master/tests/Microsoft.Bot.Builder.TestBot.Json/Samples/ToDoLuisBot/ToDoLuis.en-us.lu.dialog

However, now it uses custom parser here instead of LG, so it is incorrect. https://github.com/microsoft/botbuilder-dotnet/blob/master/libraries/Microsoft.Bot.Builder.Dialogs.Declarative/Loaders/LuisRecognizerLoader.cs

Should we use LG there?

To Reproduce

Steps to reproduce the behavior:

  1. Open Microsoft.Bot.Builder.TestBot.Json
  2. Select ToDoLuisBot

Expected behavior

Give a clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

[bug]

@boydc2014 boydc2014 added bug Indicates an unexpected problem or an unintended behavior. adaptive R8 Release 8 - March 16th, 2020 labels Dec 19, 2019
@boydc2014
Copy link
Contributor

@vishwacsena this might be a loophole that perhaps some field in dialog, we also want to be expression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. R8 Release 8 - March 16th, 2020
Projects
None yet
Development

No branches or pull requests

4 participants