Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

spk reconcile should remove rings from hld once they've been remove from a project #1118

Closed
4 tasks done
mtarng opened this issue Mar 6, 2020 · 1 comment · Fixed by CatalystCode/spk#505
Closed
4 tasks done
Assignees
Labels
effort - M less than one week effort enhancement New feature or request x-project Mapped to external projects

Comments

@mtarng
Copy link
Contributor

mtarng commented Mar 6, 2020

As a:
spk user
I want:
my hld repository to be reconciled once i remove a ring from my project

Describe the solution you'd like:
when i remove a ring via spk ring delete, I expect the project lifecycle pipeline to:

  • For each linked service in this project's bedrock.yaml, in the HLD repository:
    • Remove the ring from the service's component.yaml
    • Remove the ring directory from the service's directory.

Acceptance Criteria:

  • As a user, if I remove a ring, then the changes are reflected in: the associated bedrock.yaml, my hld repository, and the materialized repository.
    • for every service in my application reppository, every service to have the removed ring… removed
    • p-1: delete just the ring directory for every service
    • p-unicorn: delete the configuration for the ring at every level it is referenced in the HLD
    • idea: copy all config content into memory, mapped by path, blow away existing HLD, re-generate new HLD based on bedrock.yaml, emit config content in memory to config files at path.
      • ¡idempotent!

Integration test should be handled by:
#974 and #1205

Additional context:
ring management epic: #955

Does this require updates to documentation?:
yes!

@mtarng
Copy link
Contributor Author

mtarng commented Mar 6, 2020

@evanlouie @bnookala please check the acceptance criteria for this. Do we still need to save configs?

Current logic for spk hld reconcile is to blow everything away and regenerate every time?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort - M less than one week effort enhancement New feature or request x-project Mapped to external projects
Projects
None yet
2 participants