Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect publishing of full (qualified) test name - due to malformed TRX ? #7620

Closed
GraueEminenz79 opened this issue Jul 3, 2018 · 1 comment
Assignees

Comments

@GraueEminenz79
Copy link

Environment

Issue Description

Execute arbitrary NUnit3 test assembly with parametrized [TestCase]s with VSTest task (version 2.0.55)
=> Full Qualifed Test Name is parsed (or concatenated) wrongly.

testmethod_classname name

Snippet of generated .trx file

<TestMethod  
codeBase="Some.NUnit3.TestAssembly.dll"
adapterTypeName="Microsoft.VisualStudio.TestTools.TestTypes.Unit.UnitTestAdapter"
className="Some.NUnit3.TestAssembly.AssertTests.Comparison.LessOrEqualTests._LessOrEqual_NumericValues_ThrowsNothing(-25_"
name="LessOrEqual_NumericValues_ThrowsNothing(-25.0d,-25)" />

My assumption is that the last '.' is used to identify the delimiter of className and the name of the Test Case name.
But as the test case is parametrized with Parameters having "." (dots) e.g. (-25.0d,-25) the parsing goes wrong somehow.
(Same applies sometimes with the "," if the className attribute in TRX has a namespace given - which is given after a ", ", e.g.
className="SomeArbitraryClassName, ItsNameSpace"
(Or how is the semantic of className ?)

@abhishkk
Copy link
Contributor

abhishkk commented Jul 4, 2018

@GraueEminenz79 We are able to reproduce this issue and working on the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants