Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Meeting Notes, 8/11/2023 #55377

Closed
DanielRosenwasser opened this issue Aug 14, 2023 · 0 comments
Closed

Design Meeting Notes, 8/11/2023 #55377

DanielRosenwasser opened this issue Aug 14, 2023 · 0 comments
Labels
Design Notes Notes from our design meetings

Comments

@DanielRosenwasser
Copy link
Member

Formatting TypeScript

#54820

  • dprint - extremely fast, used by Deno itself.
  • Can easily support format-on-save in the checker instantaneously.
  • Looking at formatting DefinitelyTyped with a different config.
  • What's the workflow?
    • Recommend installing dprint formatting extension.
    • npm run format
    • CI checks ensure that.
  • Prettier is a lot more prescriptive. dprint is closer to gofmt or to some extent the TypeScript formatter, keeps general intent.
    • Our lines length is set to 1000 (!)
    • Some prescritive views on when to swap to multiline.
    • Still knobs if you need.
  • Some stuff that's not yet supported:
    • Single imports on the same line.
    • Space-aligned comments.
@DanielRosenwasser DanielRosenwasser added the Design Notes Notes from our design meetings label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Notes Notes from our design meetings
Projects
None yet
Development

No branches or pull requests

2 participants