-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Meeting Notes, 2/25/2022 #48042
Comments
CC @alexeagle |
Just to clarify
I think this was a point of misunderstanding in the meeting - you've said (a few times) that you won't necessarily have project references set up - how do you anticipate the editor scenarios working? |
There's nothing about Bazel that constrains users choices in this regard. In theory you configure it to run whatever One option for editors is to open the monorepo root, and the TS language service resolves first-party imports directly to the If you instead open a subdirectory in the editor, then yeah you can do a build first to populate the output tree, and afterwards the language service can resolve imports into that tree. I think pretty much every build system does a bad job of supporting this case where relative imports are to a location in the repository but not open in the editor? |
resolveFromOutDir
to Support External Build Orchestrators#37378 (comment)
You can build
foo
, and it knows its own output directory; but when it goes to import frombar
, it looks insrc/bar
instead ofdebug/bar
Feels like... maybe should have always been the behavior?
Should we enforce that
outDir
is set and disjoint from the input files?Back to this example
Weren't we exploring something more ambitious with parameterized project references?
Any concerns around editor scenarios?
foo
relies onbar
, ifbar
isn't built you'll get squiggles.How do other people use Bazel with TS?
Conclusion: would be willing to take a PR for at least an MVP of the feature so we know we're shipping something that works for Bazel users.
The text was updated successfully, but these errors were encountered: