Add navigation path for going to JS node_modules definitions instead of .d.ts declarations

[davidmurdoch]

Issue Type: Bug

When I "go to definition" of module in a JavaScript project it jumps to the TypeScript types file, if available, not the actual definition. If the TypeScript types are not available it will work as expected.

In the past, VSCode maintainers have commented:

It's not that TypeScript types are blocking you from jumping to the implementation
microsoft/vscode#68782 (comment)

and

In general, you cannot jump to the js implementation of a npm module
microsoft/vscode#68782 (comment)

and

it's that there in general is not logic to examine the code of an arbitrary node module and figure out which external invocations map to which implementations in the module.

microsoft/vscode#68782 (comment)

but that's is so clearly just flat-out wrong. There is a separate command for navigating to TypeScript types in the Right-Click context menu: "Go to Type Definition", it appears directly beneath "Go to Definition".

To reiterate: if the TypeScript file is removed everything works as expected.

People don't want to browse TypeScript definition files when stepping through source definitions. Abstractions are leaky. We need to find out why.

VS Code version: Code 1.43.2 (0ba0ca52957102ca3527cf479571617f0de6ed50, 2020-03-24T07:52:11.516Z)
OS version: Linux x64 5.0.0-16-generic

[mikeseese]

People don't want to browse TypeScript definition files when stepping through source definitions. Abstractions are leaky. We need to find out why.

I'd like to add that sometimes I do like to browse TS definition files when knowing what types I have to deal with during development; but I do agree I'd like to browse through the code during debugging.

[mjbvz]

Moving this feedback upstream

[sheerun]

The providers for "Go to Definition", "Go To Type Definition", and "Go To Implementation" currently do the same thing. It's visible on this screencast where I call them in turn: https://asciinema.org/a/619AvvIQjd3zG7IV5MoLafVec

I'd expect that only "Go to Type Definition" goes to d.ts files. Maybe "Go To Definition" and for sure "Go to Implementation" should go to JS files if they are the only ones with implementation. This is very serious issue because it makes it really hard to debug code of dependencies.

[davidmurdoch]

Any way to get this bumped to a higher priority? I go a little bit more insane every day over this 🤪

Also, the issues label is wrong. This has got to be considered a bug?

Also, not sure how this is a TypeScript issue, seems more like a VSCode issue to me.

[sheerun]

It is typescript issue and it even has failing test: #39426

[fabOnReact]

this issue affects a lot of OpenSource contributors when they try to troubleshoot issues in OpenSource repositories. I will try generating ctags to navigate the node modules https://github.com/jb55/typescript-ctags

[powext]

Definitely waiting for this!

[IllusionMH]

Is this issue still relevant?

Go to Source Definition available in VS Code from early June
https://code.visualstudio.com/updates/v1_68#_go-to-source-definition

[fabOnReact]

UPDATE: goToSourceDefinition was also added to neoclide/coc-tsserver#384. The issue was also solved with neovim. Thanks 🙏

[davidmurdoch]

Now that "Go To Source Definition" can be set as the preferred mode for "Go To Definition" (see #49003 (comment)) I think this can be closed.

[fabOnReact]

using the vim plugin coc-tsserver when I navigate to useRef, the file is still minified and unreadable.

Screen.Recording.2024-07-31.at.1.41.18.PM.mov

neoclide/coc-tsserver#449