[1.30.0] Rename ES6 object-property inside method-parameter not working

[Friksel]

After updating Vs Code to 1.30.0 renaming objects-properties used as method-parameters in an ES6 class don't rename as they should.

• VSCode Version: 1.30.0
• OS Version: Windows 10

Steps to Reproduce:

1. Have a class with an object as param
2. Rename one property of that object

Does this issue occur when all extensions are disabled?: Yes

[weswigham]

I don't think this is a bug - we rename the name used within the class, but not the name used outside of it, since that's a separate symbol (though a destructuring operation ties them together).

[weswigham]

Like, this is so intentional that it's listed as a feature on the release announcement: https://code.visualstudio.com/updates/v1_30#_renames-handle-jsts-destructuring-properly

[Friksel]

Yes this is a bug. It's unwanted behaviour and it's doing something completely different then renaming. Look at the video in my post. This is not renaming, this is adding something and changing a structure into something we don't want in Javascript and doesn't work.

The link you sent is clearly a different situation; that's about interfaces. Next to that renaming looks to work on that example, but isn't in this situation in 1.30.0.

This is how it was working in 1.29.1 and is suppose to work:

[Friksel]

Still happening in 1.30.1. Any news on this?

[justingrant]

Dupe of #29238?

[weswigham]

A per-user setting is being implemented at #29593

[justingrant]

@Friksel - Looks like this PR #29593 will be included in TypeScript 3.4 which should be out in a month or two.

[Friksel]

Thanks for the updates guys @justingrant @weswigham . Great it's changing!

[Friksel]

@justingrant I see the PR you are talking about is merged to master a while ago and this issue is closed, but in version 1.36.1 the result I get is still exactly the same as when I opened this issue, so so far I don't see any change.

Do I perhaps need to change some setting to make this work as expected?

[edit] Ah, my bad. I just in the commit message of the PR a setting has indeed been added. For future reference for people having the same issue:

• Via Settings UI: The setting is called Javascript --> Preferences --> Rename Shorthand Properties in the UI and if you remove the tick it's working as expected in Javascript.
• Via settings.json: Or just add "javascript.preferences.renameShorthandProperties": false to the settings.json