-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
signature help of tagged template doesn't show instantiated signature #23716
Labels
Bug
A bug in TypeScript
Domain: Quick Info
e.g. hover text, tool-tips, and tooltips.
Fixed
A PR has been merged for this issue
Milestone
Comments
@DanielRosenwasser wanna take a look. |
DanielRosenwasser
added
Effort: Moderate
Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual".
Help Wanted
You can do this
and removed
Effort: Moderate
Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual".
Help Wanted
You can do this
labels
Jan 31, 2020
Funny thing I found was that (foo)() doesn't instantiate |
lol at Daniel from 4 months ago |
DanielRosenwasser
added
Domain: Quick Info
e.g. hover text, tool-tips, and tooltips.
Fixed
A PR has been merged for this issue
labels
May 29, 2020
Thanks @a-tarasyuk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
A bug in TypeScript
Domain: Quick Info
e.g. hover text, tool-tips, and tooltips.
Fixed
A PR has been merged for this issue
TypeScript Version: 2.9.0-dev.20180426
Search Terms:
Code
Expected behavior:
the following signature help when hovering over
tag
:function tag<{}>(string: TemplateStringsArray, ...values: {}[]): void
function tag<number>(string: TemplateStringsArray, ...values: number[]): void
function tag<number>(string: TemplateStringsArray, ...values: number[]): void
Actual behavior:
Signature help shows
function tag<T>(string: TemplateStringsArray, ...values: T[]): void
in all cases.Signature help works as expected when calling
tag
directly using a CallExpression.Playground Link: https://agentcooper.github.io/typescript-play/#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXwygHMAeAFQD4AKAZwxi1SIC54yQBbAB2gxAGV6jIjQCCMGFACeAGngA6RQDcoEZCBqsyAbQC6ASlZKcWYAG4AUBcJEABrcs3bAEgDeARgC+D68RKpkDgAjEBgKezMgA
Related Issues:
#22873 same issue for JSX elements
#23492 PR for JSX elements
The text was updated successfully, but these errors were encountered: