Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins - support plugin specific logging #15913

Closed
egamma opened this issue May 17, 2017 · 2 comments
Closed

Plugins - support plugin specific logging #15913

egamma opened this issue May 17, 2017 · 2 comments
Labels
Declined The issue was declined as something which matches the TypeScript vision Suggestion An idea for TypeScript

Comments

@egamma
Copy link
Member

egamma commented May 17, 2017

The tslint language server plugin has to handle the situation that a tslint.json file cannot be read. The tslint API to get the configuration returns an exception in this case. There needs to be a way to show the exception to the user. The VS Code tslint extension shows this exception in the tslint output channel, see the screenshot below.

image

A plugin has access to the TS logger info.project.projectService.logger, but this log is intended for plugin authors to trace the execution of a plugin. It is not intended to be shown and understood by the end user.

What would be needed is an API that allows a plugin to send a log message event under a particular topic to the language server client. A client like VS Code can then append this message to a plugin specific output channel, in this case to the tslint channel.

// fyi @mjbvz

@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label May 24, 2017
@ArgonAlex
Copy link

ArgonAlex commented Jul 21, 2017

I was just bit by this: palantir/tslint#3063. Would have certainly saved me some time had I been able to see errors logged from the plugin.

@mhegazy mhegazy added Suggestion An idea for TypeScript and removed Needs Investigation This issue needs a team member to investigate its status. labels Nov 20, 2017
@RyanCavanaugh RyanCavanaugh removed their assignment Aug 15, 2018
@RyanCavanaugh RyanCavanaugh added the Declined The issue was declined as something which matches the TypeScript vision label Aug 15, 2018
@RyanCavanaugh
Copy link
Member

Doesn't seem to be much demand for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Declined The issue was declined as something which matches the TypeScript vision Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

4 participants