Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspaces] MS Teams was captured, but doesn't launch #34638

Open
bergamin opened this issue Sep 5, 2024 · 15 comments
Open

[Workspaces] MS Teams was captured, but doesn't launch #34638

bergamin opened this issue Sep 5, 2024 · 15 comments
Labels
Issue-Bug Something isn't working Needs-Team-Response An issue author responded so the team needs to follow up Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-Workspaces Refers to the Workspaces utility

Comments

@bergamin
Copy link

bergamin commented Sep 5, 2024

Microsoft PowerToys version

0.84.0

Installation method

PowerToys auto-update

Running as admin

Yes

Area(s) with issue?

Workspaces

Steps to reproduce

  • Capture MS Teams
  • Launch MS Teams

✔️ Expected Behavior

It to launch MS Teams

❌ Actual Behavior

It does not launch MS Teams, showing a yellow warning icon
image

Other Software

  • Windows 10
@bergamin bergamin added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 5, 2024
@plante-msft plante-msft added the Product-Workspaces Refers to the Workspaces utility label Sep 6, 2024
@ClaasBontus
Copy link

Still present in v0.84.1

@donlaci
Copy link
Collaborator

donlaci commented Dec 18, 2024

@bergamin please retest with the new 0.87 PT version and if the issue persists send a /bugreport. Thanks!

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Dec 18, 2024
@bergamin
Copy link
Author

bergamin commented Dec 19, 2024

@donlaci, still not opening. The alert icon isn't present anymore, though

/bugreport

Edit: it now shows the alert again

Image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 19, 2024
@bergamin
Copy link
Author

bergamin commented Jan 7, 2025

@donlaci, check this out... By chance I saw a similar issue occurring with Slack. If my memory serves well, I think both are Electron apps. In the Slack issue (#36672), they mention that the .exe is duplicate in the workspaces.json file, so I checked what it shows for MS Teams and it's even more puzzling:

Image

I use Vivaldi as my default browser. Maybe instead of packaging a browser within the Electron app, MS chose to use the user's default browser to launch the app? I'm really confused. I also have a MS Teams PWA set up, but it was not recorded. I recorded the actual app.

For reference, this is what a recorded PWA looks like (it doesn't work with Vivaldi (#34572), but just for reference):

Image

And this is what Vivaldi itself looks like:

Image

@donlaci
Copy link
Collaborator

donlaci commented Jan 7, 2025

@bergamin Thank you for helping to solve the issue!
I don't have an explanation for the issue, but there are some facts:
The PWA apps are implemented currently only for edge and chrome, not for vivaldi. Both, edge and chrome use edge_proxy.exe and chrome_proxy.exe with a pwa_app_id as parameter to launch a pwa (inside the browser).
The MS Teams in the workspace.json file looks like as if it would be launched as a PWA under vivaldi. Which currently is not supported, sorry for that.
If the MSTeams is a "normal", non-PWA app, it should launch and we will check why it does not, if you send us a bugreport.
If the MSTeams is a PWA app under vivaldi, then you might be able to fix it manually as a temporaly workaround, sorry for the inconvenience.
If you have a desktop shrotcut for the MSTeams app, you will find the vivaldi_proxy.exe as the target and also you will find the cli args needed for the launch. You can edit your workspaces.json file: remove the \\ms-teams.exe from the application-path (and have the vivaldi_proxy.exe) and add the args too. Basically "copy" the desktop shortcut. It might work. (I am not familiar with vivaldi, so if it won't work, then take my appology).
Thanks!

@bergamin
Copy link
Author

bergamin commented Jan 7, 2025

Yes, I'm as puzzled as you are. It's not a PWA and this issue is the bug report. Also, Windows doesn't let me see the shortcut details for MS Teams, neither on the taskbar nor on the Start menu, so I have no idea where it's actually installed at.

Image

I guess it's worth mentioning that this MS Teams installation was automatic after a reestructuration of Teams. The old one is still installed under the name "Teams Classic".

Yes, I know Vivaldi PWAs don't work with Workspaces. That's why I mentioned it just to clarify that in this case it's not a PWA.

But I'll try your suggestion and fiddle with the shortcut target of the PWAs I have. These ones Windows do let me see the shortcut details.

@bergamin
Copy link
Author

bergamin commented Jan 8, 2025

I found it by using PowerToys Run (tested opening through Run to see if it would fill the taskbar shortcut and it is it)

Image

It seems to be a MS Store app. MS Store is blocked in this PC. Could this be a clue?

Unfortunately I can't test this URL right now because of this other bug: #36749

@bergamin
Copy link
Author

bergamin commented Jan 8, 2025

@donlaci just to clarify, when you say "send a bug report", you mean like GitHub isn't the place for a bug report? is there another place to report?

@donlaci
Copy link
Collaborator

donlaci commented Jan 8, 2025

@bergamin We prefer github.
You right click on our system tray icon and just go to report bug. Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks!
Image

@bergamin
Copy link
Author

bergamin commented Jan 8, 2025

Ah, I see. Thanks for the clarification. I was afraid you were going to tell me to use Feedback Hub 😆

Here it goes

PowerToysReport_2025-01-08-10-10-52.zip

@donlaci
Copy link
Collaborator

donlaci commented Feb 21, 2025

@bergamin thanks for the feedback.
I think the problem is in your case, that you are trying to launch MS Teams as a PWA app inside the Vivaldi browser. Your workspaces.json file contains this:
"application-path": "C:\\Users\\10087138\\AppData\\Local\\Vivaldi\\Application\\vivaldi_proxy.exe\\ms-teams.exe",
Unfortunately the Vivaldi browser is not supported for PWA apps, only Edge and Chrome.
As a workaround (until Vivaldi support gets implemented) you might try:

  • using a standalone MS Team app
  • try to "fix" your workspaces.json file, located in
    "C:\Users\ XXX \AppData\Local\Microsoft\PowerToys\Workspaces\workspaces.json"
    by replacing
    "application-path": "C:\\Users\\10087138\\AppData\\Local\\Vivaldi\\Application\\vivaldi_proxy.exe\\ms-teams.exe",
    to
    "application-path": "C:\\Users\\10087138\\AppData\\Local\\Vivaldi\\Application\\vivaldi_proxy.exe",
    and adding a cli argument with the app-id of your MSTeams PWA app. It will look like this
    "command-line-arguments": "--app-id=filomnlgoonmibfibajlilbckhkhifea",
    You cen get the app id from a shortcut, just create one shortcut for your MSTeams and look into shortcut properties. The Target field should contain your app-id.

By the way, your workspace.json was created by the PT 0.84 tool, I would recommend to update PT to the latest version and re-create your workspaces, many things were added racently.
Good luck!

@bergamin
Copy link
Author

bergamin commented Feb 21, 2025

Hello, @donlaci. The MS Teams that was recorded was not the PWA version. If it were, triggering the workspace would open a Vivaldi window like it happens to Spotify and Outlook.

Maybe because I have a PWA version as well, the workspace could be recording it wrong, mixing up the two...

I'll try recording just MS Teams and something else that's not Vivaldi or a PWA to see if it helps

@donlaci
Copy link
Collaborator

donlaci commented Feb 21, 2025

@bergamin Thanks for your feedback. It helps.
In this case, would you be please update to PT 0.88, retest the scenario (snapshotting MSTeams, launching) and if the issue persist, send an updated bugreport? Thanks!

@bergamin
Copy link
Author

bergamin commented Feb 21, 2025

Image

PowerToysReport_2025-02-21-14-14-44.zip

BTW, I think it would be very helpful if the bug report thing told the user it can take a couple minutes to generate, because I clicked the thing like 3 or 4 times before the dialog appeared and was ready to report it not generating bug reports as a bug

@donlaci
Copy link
Collaborator

donlaci commented Feb 21, 2025

@bergamin Thenk you for the bugreport and for the record too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Needs-Team-Response An issue author responded so the team needs to follow up Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-Workspaces Refers to the Workspaces utility
Projects
Status: No status
Development

No branches or pull requests

4 participants