Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate and fix possible breaking changes in Extension projects #162

Closed
AndreyTretyak opened this issue Mar 3, 2020 · 1 comment · Fixed by #169
Closed

Investigate and fix possible breaking changes in Extension projects #162

AndreyTretyak opened this issue Mar 3, 2020 · 1 comment · Fixed by #169
Assignees
@AndreyTretyak

Comments

@AndreyTretyak
Copy link
Contributor

New Extension projects have changes in EventSource contract that could break our logging. They are marked in code by Breaking Change: comments and explanation.
@AndreyTretyak AndreyTretyak self-assigned this Mar 3, 2020
@AndreyTretyak AndreyTretyak mentioned this issue Mar 3, 2020
Merged
@AndreyTretyak
Copy link
Contributor Author

AndreyTretyak commented Mar 13, 2020 •
edited
Loading

Main changes to check and follow-up:

  1. CorrelationId now string and not Guid, maybe we should track both fields separate to support both scenarios
  2. We need to enable Activity transfer via SF internal protocols
  3. Track all ETW event changes and update our log aggregation
  4. Investigate the ability to skip logging activity due to compliance reasons.
  5. Track performance changes due to switch of logger and timedscopes

@AndreyTretyak AndreyTretyak linked a pull request Mar 18, 2020 that will close this issue
Add guid correlation support and change activity processing #169
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreyTretyak AndreyTretyak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add guid correlation support and change activity processing microsoft/Omex
1 participant
@AndreyTretyak