Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXOATPBuiltInProtectionRule/EXOEOPProtectionRule: Test doesn't work if properties are empty #5394

Closed
ricmestre opened this issue Nov 13, 2024 · 0 comments · Fixed by #5395 or #5397
Closed

Comments

@ricmestre
Copy link
Contributor

Description of the issue

Some of the properties used in EXOATPBuiltInProtectionRule/EXOEOPProtectionRule are set as arrays in DSC, where you can define them as empty but EXO stores that information as simple null strings so even though the deployment works when calling Test-DscConfiguration the test fails because it compares $null to @()

I have a simple fix for both of them which I'll open a PR for.

Microsoft 365 DSC Version

1.24.1106.3

Which workloads are affected

Exchange Online

The DSC configuration

EXOATPBuiltInProtectionRule "EXOATPBuiltInProtectionRule-ATP Built-In Protection Rule"
        {
            Credential                = $Credscredential;
            Identity                  = "ATP Built-In Protection Rule";
            ExceptIfRecipientDomainIs = @();
        }
        EXOEOPProtectionPolicyRule "EXOEOPProtectionPolicyRule-Strict Preset Security Policy"
        {
            Credential                = $Credscredential;
            Ensure                    = "Present";
            ExceptIfRecipientDomainIs = @();
            Identity                  = "Strict Preset Security Policy";
            Name                      = "Strict Preset Security Policy";
            Priority                  = 0;
            State                     = "Enabled";
        }

Verbose logs showing the problem

N/A

Environment Information + PowerShell Version

Win11/PS5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant