Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Authoring] Support for a default WinRT.Host.runtimeconfig #735

Closed
j0shuams opened this issue Feb 9, 2021 · 2 comments
Closed

[Authoring] Support for a default WinRT.Host.runtimeconfig #735

j0shuams opened this issue Feb 9, 2021 · 2 comments
Assignees
Labels
authoring Related to authoring feature work bug Something isn't working
Milestone

Comments

@j0shuams
Copy link
Contributor

j0shuams commented Feb 9, 2021

Describe the bug
Have C#/WinRT authored components generate their own runtimeconfig file and have it copied out to project/package references. Also add a property that allows authors to disable this behavior, and trust them to handle it.

Child task of #663

@j0shuams j0shuams added the bug Something isn't working label Feb 9, 2021
@j0shuams j0shuams self-assigned this Feb 9, 2021
@j0shuams j0shuams added this to the Release 1.1.2 milestone Feb 9, 2021
@manodasanW manodasanW added the authoring Related to authoring feature work label Feb 11, 2021
@angelazhangmsft angelazhangmsft modified the milestones: Release 1.1.2, Preview 1.1.3 Feb 18, 2021
@j0shuams
Copy link
Contributor Author

j0shuams commented Mar 3, 2021

From my investigation, ProjectReferences might not be able to get this support because the runtimeconfig is generated later in the build, and is not available as an item to set as Content at the top-level, which is how we support the dlls flowing. For package reference we can put this runtimeconfig in the package and then have it be copied out just like the DLLs.

@j0shuams
Copy link
Contributor Author

Done in #765

@angelazhangmsft angelazhangmsft modified the milestones: Preview 1.1.4, Release 1.1.4 Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authoring Related to authoring feature work bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants