Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove 'InitProperty' type in Composer #2096

Merged
merged 2 commits into from
Feb 26, 2020
Merged

chore: remove 'InitProperty' type in Composer #2096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db66ceb
disable InitProperty entry
yeze322 Feb 26, 2020
c877f86
remove InitProperty definition
yeze322 Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Composer/packages/extensions/obiformeditor/demo/src/editorschema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@
"Microsoft.IfCondition": {
"title": "Branch: If/Else"
},
"Microsoft.InitProperty": {
"title": "Initialize Property"
},
"Microsoft.OnIntent": {
"title": "Intent"
},
Expand Down
2 changes: 1 addition & 1 deletion Composer/packages/extensions/visual-designer/demo/src/samples/todo/AddToDo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"condition": "user.todos == null",
"actions": [
{
"$type": "Microsoft.InitProperty",
"$type": "Microsoft.SetProperty",
"$designer": {
"createdAt": "2019-07-16T20:01:05.970Z",
"updatedAt": "2019-07-16T20:01:13.866Z",
Expand Down
1 change: 0 additions & 1 deletion Composer/packages/extensions/visual-designer/demo/src/stories/VisualSDKDemo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export class VisualSDKDemo extends Component {
const initialTypes = [
SDKTypes.SendActivity,
SDKTypes.EditArray,
SDKTypes.InitProperty,
SDKTypes.SetProperties,
SDKTypes.SetProperty,
SDKTypes.DeleteProperties,
Expand Down
4 changes: 0 additions & 4 deletions Composer/packages/extensions/visual-designer/src/schema/uischema.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,6 @@ export const uiSchema: UISchema = {
'ui:widget': ActionCard,
content: data => `${data.changeType} {${data.itemsProperty || '?'}}`,
},
[SDKTypes.InitProperty]: {
'ui:widget': ActionCard,
content: data => `{${data.property || '?'}} = new ${data.type || '?'}`,
},
[SDKTypes.SetProperty]: {
'ui:widget': ActionCard,
content: data => `{${data.property || '?'}} = ${data.value || '?'}`,
Expand Down
27 changes: 0 additions & 27 deletions Composer/packages/lib/shared/src/appschema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,11 +1400,6 @@ export const appschema: OBISchema = {
description: 'Two-way branch the conversation flow based on a condition.',
$ref: '#/definitions/Microsoft.IfCondition',
},
{
title: 'Microsoft.InitProperty',
description: 'Define and initialize a property to be an array or object.',
$ref: '#/definitions/Microsoft.InitProperty',
},
{
title: 'Microsoft.LogAction',
description:
Expand Down Expand Up @@ -1700,28 +1695,6 @@ export const appschema: OBISchema = {
},
},
},
'Microsoft.InitProperty': {
$role: 'unionType(Microsoft.IDialog)',
title: 'Initialize property',
description: 'Define and initialize a property to be an array or object.',
type: 'object',
properties: {
...$properties(SDKTypes.InitProperty),
property: {
$role: 'expression',
title: 'Property',
description: 'Property (named location to store information).',
examples: ['user.age'],
type: 'string',
},
type: {
type: 'string',
title: 'Type',
description: 'Type of value.',
enum: ['object', 'array'],
},
},
},
'Microsoft.IpEntityRecognizer': {
$role: 'unionType(Microsoft.EntityRecognizers)',
title: 'Ip Entity Recognizer',
Expand Down
3 changes: 0 additions & 3 deletions Composer/packages/lib/shared/src/labelMap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ export const ConceptLabels: { [key in ConceptLabelKey]?: LabelOverride } = {
[SDKTypes.IfCondition]: {
title: formatMessage('Branch: if/else'),
},
[SDKTypes.InitProperty]: {
title: formatMessage('Initialize a property'),
},
[SDKTypes.LanguagePolicy]: {
title: formatMessage('LanguagePolicy'),
},
Expand Down
1 change: 0 additions & 1 deletion Composer/packages/lib/shared/src/types/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export enum SDKTypes {
HashtagEntityRecognizer = 'Microsoft.HashtagEntityRecognizer',
HttpRequest = 'Microsoft.HttpRequest',
IfCondition = 'Microsoft.IfCondition',
InitProperty = 'Microsoft.InitProperty',
IpEntityRecognizer = 'Microsoft.IpEntityRecognizer',
LanguagePolicy = 'Microsoft.LanguagePolicy',
LogAction = 'Microsoft.LogAction',
Expand Down
1 change: 0 additions & 1 deletion Composer/packages/lib/shared/src/viewUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ export const dialogGroups: DialogGroupsMap = {
types: [
SDKTypes.SetProperty,
SDKTypes.SetProperties,
SDKTypes.InitProperty,
SDKTypes.DeleteProperty,
SDKTypes.DeleteProperties,
SDKTypes.EditArray,
Expand Down
5 changes: 0 additions & 5 deletions Composer/packages/server/schemas/editor.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,6 @@
"helpLink": "https://aka.ms/bfc-controlling-conversation-flow",
"helpLinkText": "Learn more"
},
"Microsoft.InitProperty": {
"title": "Initialize Property",
"helpLink": "https://aka.ms/bfc-using-memory",
"helpLinkText": "Learn more"
},
"Microsoft.LanguagePolicy": {
"title": "LanguagePolicy"
},
Expand Down