refactor: update the validation for new schema #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
reviewed
Feb 13, 2020
Composer/packages/lib/indexers/src/dialogUtils/dialogChecker.ts
Outdated
Show resolved
Hide resolved
compulim
reviewed
Feb 13, 2020
compulim
reviewed
Feb 13, 2020
compulim
reviewed
Feb 13, 2020
cwhitten
added a commit
that referenced
this pull request
Feb 13, 2020
* update package version in template * add error throw in script * update netcoreapp version to 3.1 * update schema to 4.7.2 sdk version * form editor expression err for new schema * update dotnet sdk in docker * update dotnet sdk version validation * update sdk version validation * refactor: update the validation for new schema (#1988) * update the validation * fix some comments * update some logic * fix unit test Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: leileizhang <leilzh@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
microsoft/botbuilder-dotnet#3253
Task Item
refs #1939
Screenshots