From a067ea9767d12e93f5a9ceed063df290a7e6993a Mon Sep 17 00:00:00 2001 From: Shuai Wang Date: Wed, 22 Jan 2020 15:56:50 +0800 Subject: [PATCH 1/2] fix LU LSP suggest empty string entities and roles --- .../language-understanding/src/matchingPattern.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts b/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts index 6f1cc9fec2..a51e82754e 100644 --- a/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts +++ b/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts @@ -130,7 +130,7 @@ export function getSuggestionEntities(luisJson: any, suggestionEntityTypes: stri suggestionEntityTypes.forEach(entityType => { if (luisJson[entityType] !== undefined && luisJson[entityType].length > 0) { luisJson[entityType].forEach(entity => { - if (entity) { + if (entity && entity.name.length > 0) { suggestionEntityList.push(entity.name); } }); @@ -177,7 +177,9 @@ export function getSuggestionRoles(luisJson: any, suggestionEntityTypes: string[ luisJson[entityType].forEach(entity => { if (entity.roles !== undefined && entity.roles.length > 0) { entity.roles.forEach(role => { - suggestionRolesList.push(role); + if (role.length > 0) { + suggestionRolesList.push(role); + } }); } }); From 7705dfdd88c9ac08c74b80768cb409845d64def9 Mon Sep 17 00:00:00 2001 From: Shuai Wang Date: Tue, 4 Feb 2020 14:50:44 +0800 Subject: [PATCH 2/2] fix comments --- .../language-understanding/src/matchingPattern.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts b/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts index a51e82754e..368768c2b9 100644 --- a/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts +++ b/Composer/packages/tools/language-servers/language-understanding/src/matchingPattern.ts @@ -130,7 +130,7 @@ export function getSuggestionEntities(luisJson: any, suggestionEntityTypes: stri suggestionEntityTypes.forEach(entityType => { if (luisJson[entityType] !== undefined && luisJson[entityType].length > 0) { luisJson[entityType].forEach(entity => { - if (entity && entity.name.length > 0) { + if (entity && entity.name) { suggestionEntityList.push(entity.name); } }); @@ -177,7 +177,7 @@ export function getSuggestionRoles(luisJson: any, suggestionEntityTypes: string[ luisJson[entityType].forEach(entity => { if (entity.roles !== undefined && entity.roles.length > 0) { entity.roles.forEach(role => { - if (role.length > 0) { + if (role) { suggestionRolesList.push(role); } });