diff --git a/Composer/packages/extensions/visual-designer/src/components/nodes/layout-steps/BaseInput.tsx b/Composer/packages/extensions/visual-designer/src/components/nodes/layout-steps/BaseInput.tsx index f824bea719..1254e18c35 100644 --- a/Composer/packages/extensions/visual-designer/src/components/nodes/layout-steps/BaseInput.tsx +++ b/Composer/packages/extensions/visual-designer/src/components/nodes/layout-steps/BaseInput.tsx @@ -36,17 +36,17 @@ export const BaseInput: FC = ({ id, data, onEvent, onResize }): JSX.E return (
- + - + - + diff --git a/Composer/packages/extensions/visual-designer/src/components/nodes/layout-steps/Foreach.tsx b/Composer/packages/extensions/visual-designer/src/components/nodes/layout-steps/Foreach.tsx index cc31e9c421..58019c4ac6 100644 --- a/Composer/packages/extensions/visual-designer/src/components/nodes/layout-steps/Foreach.tsx +++ b/Composer/packages/extensions/visual-designer/src/components/nodes/layout-steps/Foreach.tsx @@ -75,7 +75,7 @@ export const Foreach: FunctionComponent = ({ id, data, onEvent, onRes return (
- + = ({ id, data, onEvent, o return (
- + = ({ id, data, onEven return (
- + void; + onClick?: () => void; children?: any; } export const FormCard: FunctionComponent = ({ @@ -54,8 +54,10 @@ export const FormCard: FunctionComponent = ({ data-testid="FormCard" css={[containerStyle, { ...styles }]} onClick={e => { - e.stopPropagation(); - onClick(); + if (typeof onClick === 'function') { + e.stopPropagation(); + onClick(); + } }} >
any; } -export const ElementWrapper: FC = ({ id, tab, children }): JSX.Element => { +export const ElementWrapper: FC = ({ id, tab, onEvent, children }): JSX.Element => { const selectableId = tab ? `${id}${tab}` : id; const { focusedId, focusedEvent, focusedTab } = useContext(NodeRendererContext); const { selectedIds, getNodeIndex } = useContext(SelectionContext); @@ -62,6 +64,10 @@ export const ElementWrapper: FC = ({ id, tab, children }): } `} {...declareElementAttributes(selectableId, id)} + onClick={e => { + e.stopPropagation(); + onEvent(NodeEventTypes.Focus, { id, tab }); + }} > {children}
diff --git a/Composer/packages/extensions/visual-designer/src/components/renderers/StepRenderer.tsx b/Composer/packages/extensions/visual-designer/src/components/renderers/StepRenderer.tsx index 6dfe14d70c..0d2fd5a9b7 100644 --- a/Composer/packages/extensions/visual-designer/src/components/renderers/StepRenderer.tsx +++ b/Composer/packages/extensions/visual-designer/src/components/renderers/StepRenderer.tsx @@ -65,7 +65,11 @@ export const StepRenderer: FC = ({ id, data, onEvent, onResize }): JS return content; } - return {content}; + return ( + + {content} + + ); }; StepRenderer.defaultProps = defaultNodeProps; diff --git a/Composer/packages/extensions/visual-designer/src/widgets/ActionCard.tsx b/Composer/packages/extensions/visual-designer/src/widgets/ActionCard.tsx index fc01237ecd..6f5a2fc331 100644 --- a/Composer/packages/extensions/visual-designer/src/widgets/ActionCard.tsx +++ b/Composer/packages/extensions/visual-designer/src/widgets/ActionCard.tsx @@ -7,7 +7,6 @@ import { generateSDKTitle } from '@bfc/shared'; import { FormCard } from '../components/nodes/templates/FormCard'; import { WidgetContainerProps, WidgetComponent } from '../schema/uischema.types'; import { ObiColors } from '../constants/ElementColors'; -import { NodeEventTypes } from '../constants/NodeEventTypes'; import { NodeMenu } from '../components/menus/NodeMenu'; export interface ActionCardProps extends WidgetContainerProps { @@ -43,7 +42,6 @@ export const ActionCard: WidgetComponent = ({ icon={icon} label={content} nodeColors={nodeColors} - onClick={() => onEvent(NodeEventTypes.Focus, { id })} /> ); }; diff --git a/Composer/packages/extensions/visual-designer/src/widgets/ActivityRenderer.tsx b/Composer/packages/extensions/visual-designer/src/widgets/ActivityRenderer.tsx index 9fd5dd66f9..7532c21eaa 100644 --- a/Composer/packages/extensions/visual-designer/src/widgets/ActivityRenderer.tsx +++ b/Composer/packages/extensions/visual-designer/src/widgets/ActivityRenderer.tsx @@ -5,7 +5,6 @@ import React from 'react'; import { generateSDKTitle } from '@bfc/shared'; import get from 'lodash/get'; -import { NodeEventTypes } from '../constants/NodeEventTypes'; import { ElementIcon } from '../utils/obiPropertyResolver'; import { NodeMenu } from '../components/menus/NodeMenu'; import { FormCard } from '../components/nodes/templates/FormCard'; @@ -49,9 +48,6 @@ export const ActivityRenderer: React.FC = ({ icon={icon} corner={} nodeColors={nodeColors} - onClick={() => { - onEvent(NodeEventTypes.Focus, { id }); - }} /> ); }; diff --git a/Composer/packages/extensions/visual-designer/src/widgets/DialogRefCard.tsx b/Composer/packages/extensions/visual-designer/src/widgets/DialogRefCard.tsx index 1d93f49e5d..9b90ed157e 100644 --- a/Composer/packages/extensions/visual-designer/src/widgets/DialogRefCard.tsx +++ b/Composer/packages/extensions/visual-designer/src/widgets/DialogRefCard.tsx @@ -54,7 +54,6 @@ export const DialogRefCard: WidgetComponent = ({ corner={} label={typeof getRefContent === 'function' ? getRefContent(dialogRef) : dialogRef} nodeColors={nodeColors} - onClick={() => onEvent(NodeEventTypes.Focus, { id })} /> ); };