Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove the unused lufiles in notifications #1758

Closed
wants to merge 1 commit into from
Closed

fix: Remove the unused lufiles in notifications #1758

wants to merge 1 commit into from

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Dec 11, 2019 •
edited
Loading

Description

filter the luFiles that are used by dialogs.

Task Item

closes #1744

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

luis

@lei9444 lei9444 closed this Dec 11, 2019
@lei9444 lei9444 reopened this Dec 11, 2019
@lei9444 lei9444 closed this Dec 11, 2019
@lei9444 lei9444 deleted the fix branch December 11, 2019 14:00
@lei9444 lei9444 restored the fix branch December 11, 2019 14:01
@lei9444 lei9444 reopened this Dec 11, 2019
@lei9444 lei9444 changed the base branch from stable to master December 11, 2019 14:27
@lei9444 lei9444 closed this Dec 11, 2019
@lei9444 lei9444 deleted the fix branch January 17, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lei9444