-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show error message in form editor. #1737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor feedback. I will do a functional test today.
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
Couple more things:
|
Composer/packages/extensions/obiformeditor/src/Form/widgets/ExpressionWidget.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanlong9278 I think this is good to go. Can you test more scenarios today?
I did find a couple of things unrelated to this change: #1742 #1744
efbf7b2
to
c3fffd6
Compare
I have tested different scenarios, it runs well. |
@a-b-r-o-w-n There are two items changed.
|
Description
Sync diagnostics info with notification page in form editor, includes lg, lu and expression dianostics.
Task Item
closes #1699
closes #1715
Type of change
Please delete options that are not relevant.
Checklist
Screenshots