Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Align with the new design in form for inline error display #1683

Merged
merged 12 commits into from
Dec 4, 2019
Merged

feat: Align with the new design in form for inline error display #1683

merged 12 commits into from
Dec 4, 2019

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Dec 2, 2019 •
edited
Loading

Description

Align with the new design in form for inline error display

Discussion

  • Show detail error message.(Now the error message is fixed)
  • Notification level. (Now only show error message, but notification message has 2 levels in notification page: warninig & error).

Task Item

closes #1623

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

validation

a-b-r-o-w-n
a-b-r-o-w-n requested changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this scale to all other form fields? We are not surfacing errors outside of the expression widget, but what happens when we do?

@a-b-r-o-w-n
Copy link
Contributor

Also, I didn't see anything to handle lint warnings. The spec is that we display an error if present, then a warning.

@boydc2014 boydc2014 mentioned this pull request Dec 4, 2019
Closed
7 tasks
@github-actions
Copy link

github-actions bot commented Dec 4, 2019

Coverage Status

Coverage decreased (-0.03%) to 41.001% when pulling c8f95dd on julong/validation into 730433c on master.

@a-b-r-o-w-n
Copy link
Contributor

Note: What this change does not do is surface errors for any arbitrary field in the form. Only LG, LU and expression errors are surfaced right now.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 997df62 into master Dec 4, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the julong/validation branch December 4, 2019 23:06
@cwhitten cwhitten mentioned this pull request Dec 4, 2019
Closed
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanlong9278 @a-b-r-o-w-n @cwhitten