Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: changes to bot creation #1613

Merged
merged 3 commits into from
Nov 20, 2019
Merged

revert: changes to bot creation #1613

merged 3 commits into from
Nov 20, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Nov 20, 2019 •
edited
Loading

Description

These commits have introduced some bugs in the creation of bots and breaks current users of Composer by changing the shape of data.json. We need to revert for now so we can cut a stable release with a P0 fix.

refs #1583
refs #1548

@a-b-r-o-w-n a-b-r-o-w-n changed the base branch from stable to master November 20, 2019 18:38
@a-b-r-o-w-n a-b-r-o-w-n merged commit e0e578a into microsoft:master Nov 20, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the revert-commits branch November 20, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@benbrown benbrown Awaiting requested review from benbrown

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@luhan2017 luhan2017 Awaiting requested review from luhan2017

@yeze322 yeze322 Awaiting requested review from yeze322

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-b-r-o-w-n @cwhitten @liweitian