Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hackathon] Duplicate trigger names should not be allowed in the same dialog #976

Closed
v-kydela opened this issue Sep 27, 2019 · 1 comment
Assignees
Labels
Area: Shell Hackathon 9/27 BFC-Hackathon 9/27 UX Design Need UX Design

Comments

@v-kydela
Copy link

Describe the bug

It's unclear what purpose trigger names serve when the name isn't used to identify an intent, but I would think the name should at least differentiate the trigger from other triggers. They can only serve that purpose if uniqueness is enforced.

To Reproduce

Steps to reproduce the behavior:

  1. Add a trigger to a dialog
  2. Add another trigger to that dialog with the same name
  3. See lack of error

Expected behavior

There should be some kind of message that says the name is already taken.

Screenshots

image

[bug]

@v-kydela v-kydela added Needs-triage A new issue that require triage Type: Bug Something isn't working labels Sep 27, 2019
@a-b-r-o-w-n a-b-r-o-w-n added Hackathon 9/27 BFC-Hackathon 9/27 Type: suggestion Area: Shell UX Design Need UX Design and removed Type: Bug Something isn't working Needs-triage A new issue that require triage labels Sep 30, 2019
@sangwoohaan
Copy link
Contributor

Will be addressed in #778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Shell Hackathon 9/27 BFC-Hackathon 9/27 UX Design Need UX Design
Projects
None yet
Development

No branches or pull requests

3 participants