Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify trigger name usage #932

Closed
boydc2014 opened this issue Sep 23, 2019 · 3 comments
Closed

Clarify trigger name usage #932

boydc2014 opened this issue Sep 23, 2019 · 3 comments
Assignees
Labels
Area: LU Belongs to LU feature area

Comments

@boydc2014
Copy link
Contributor

In our trigger wizzard design, we require a "name" for each trigger type.

The issue is:

  1. If this is not a "intent trigger", it's highly likely no trigger with same type (because same type trigger with only fire the first one), so that trigger type can be used to identify this trigger, and it's very clearly to use trigger type instead of an arbitrary name.

  2. If this is a "intent trigger", i'm not sure how we handle the confusion between trigger name with "intent name"

My feeling is if trigger name can't be added in a consistent way, it's more confusing than being helpful.

My proposal is we remove trigger name from new trigger wizzard. On the left nav, we can show intent name of intent trigger, and trigger type for other type of trigger.

@vishwacsena
Copy link
Contributor

Current experience does not yet (AFAIK) implement the default naming spec here - #778

I believe with default naming implemented, the experience would not be jarring.

It is totally conceivable that there are more than one instance of a specific trigger type - each trigger does support a condition so you could have a constraint applied to the same trigger type for different behavior.

The other down-side to removing trigger name is managed LU - we need an intent name for both triggers as well as inputs. Without a trigger name, you will be naming an intent for the trigger but we will use the default input name elsewhere. It is just more consistent for us to have a name and give it a default value.

@sangwoohaan
Copy link
Contributor

Posting updated design with minor tweaks here
https://www.figma.com/file/04DymSq4xElhOBdAyutvvTbq/Composer-SH-06.19?node-id=2270%3A83

@sangwoohaan
Copy link
Contributor

Closing this since the name fields are removed from the trigger wizards for now, but we should circle back to this issue in the future once Managed LU is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LU Belongs to LU feature area
Projects
None yet
Development

No branches or pull requests

7 participants