Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to define event type for a new trigger #860

Closed
yochay opened this issue Sep 13, 2019 · 4 comments · Fixed by #892
Closed

No way to define event type for a new trigger #860

yochay opened this issue Sep 13, 2019 · 4 comments · Fixed by #892
Assignees
Labels
4.6 Area: Form Editor P0 Must Fix. Release-blocker Public Preview Type: Bug Something isn't working

Comments

@yochay
Copy link
Contributor

yochay commented Sep 13, 2019

When creating a new Trigger, we used to allow developer to choose the even type. That drop down is missing from property form for Trigger

image

@yochay yochay added Type: Bug Something isn't working Area: Form Editor P0 Must Fix. Release-blocker 4.6 labels Sep 13, 2019
@yochay
Copy link
Contributor Author

yochay commented Sep 13, 2019

There is a DCR on the SDK microsoft/botbuilder-dotnet#2326 that we can use Composer to make a call on what we expose via Composer vs. SDK.

@sangwoohaan, what would be a good way to design generic 'advance' topics for drop downs / multi-choice options in Composer.

Suggesting to surface the following:

Name Description Base event Constraint Use case Keep ?
OnEvent Generic event handler
OnIntent RecognizedIntent turn.recognized.intent == 'IntentName'
OnUnknownIntent UnknownIntent
OnBeginDialog BeginDialog N/A
OnConversationUpdateActivity ActivityRecieved ActivityTypes.ConversationUpdate

These can be surfaced under 'advance'

Name Description Base event Constraint Use case Keep ?
OnActivity \/ ActivityRecieved N/A
OnEndOfConversationActivity ActivityRecieved ActivityTypes.EndOfConversation
OnEventActivity ActivityRecieved ActivityTypes.Event
OnHandoffActivity ActivityRecieved ActivityTypes.Handoff
OnInvokeActivity ActivityRecieved ActivityTypes.Invoke
OnMessageActivity ActivityRecieved ActivityTypes.Message
OnMessageDeletionActivity ActivityRecieved ActivityTypes.MessageDeletion
OnMessageReactionActivity ActivityRecieved ActivityTypes.MessageReaction
OnMessageUpdateActivity ActivityRecieved ActivityTypes.MessageUpdate
OnTypingActivity ActivityRecieved ActivityTypes.Typing

@sangwoohaan
Copy link
Contributor

Related to #825? @luhan2017 and I are gonna talk about this next week

@a-b-r-o-w-n
Copy link
Contributor

@sangwoohaan @yochay We should explore a similar UX to the new prompts editor.

@sangwoohaan
Copy link
Contributor

sangwoohaan commented Sep 18, 2019

Do we need to give special treatment to OnBeginDialog and OnConversationUpdateActivity when we automatically create them for the users? OnCoversationUpdateActivity is create for root dialogs, and OnBeginDialog for sub dialogs. I suggest we only surface OnIntent, OnEvent, OnUnknownIntent, and put everything under OnEvent as sub-selection. Thoughts? @yochay @cwhitten @luhan2017

@yochay yochay mentioned this issue Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 Area: Form Editor P0 Must Fix. Release-blocker Public Preview Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants