Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Customer Managed Keys (CMK) #8213

Closed
clearab opened this issue Jun 29, 2021 · 1 comment
Closed

Enable Customer Managed Keys (CMK) #8213

clearab opened this issue Jun 29, 2021 · 1 comment
Labels
feature-request A request for new functionality or an enhancement to an existing one.

Comments

@clearab
Copy link

clearab commented Jun 29, 2021

The work would likely involve:

  1. Add ability for composer user to turn on the feature and specify the key url
    a. Consider having a key vault key picker (more user friendly but it’s more work)
  2. Pass the key url when creating/updating the bot
  3. Error handling/surfacing
    a. Failure: invalid key url, missing permissions
    b. If target subscription has policy to disallow non-CMK bot, composer should return a clear error if deployment of a bot fails for that reason
  4. Likely want the ability to retrieve the state of CMK for an existing bot to pre-populate the settings (see Update README.md #1 above)
    a. Also consider how conflict between local and remote settings are handled (e.g. does it pick one silently or does it expose the conflict?)
  5. Nice to have: do we want to help them with
    a. Create vault/key?
    b. Set up vault permissions (or report on what’s missing)
@clearab clearab added the feature-request A request for new functionality or an enhancement to an existing one. label Jun 29, 2021
@clearab
Copy link
Author

clearab commented Jun 29, 2021

Closing as duplicate of: #5682

@clearab clearab closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality or an enhancement to an existing one.
Projects
None yet
Development

No branches or pull requests

1 participant