Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly Build e678bd7 - cannot choose Profiles to Publish to #5398

Closed
DS2019 opened this issue Dec 21, 2020 · 10 comments · Fixed by #5399
Closed

Nightly Build e678bd7 - cannot choose Profiles to Publish to #5398

DS2019 opened this issue Dec 21, 2020 · 10 comments · Fixed by #5399
Assignees
Labels
Area: Publish Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. Team: Runtime & Publishing Type: Bug Something isn't working

Comments

@DS2019
Copy link

DS2019 commented Dec 21, 2020

Hi @tonyanziano

I've installed the latest nightly build and got further than I have before with trying to Publish to PVA from the Bot Framework Composer. However, it is not allowing me to choose a profile to publish to.
I had a publish profile of "Publish Bot to Azure" and added one to "Publish to PVA" - this time it found all 4 bots in my test tenant environment. However, when I go to the screen "Publish your bots" I cannot actually choose "Publish to PVA" as so:
CannotPublishtoPVAProfile
When I click the "Publish to PVA" profile, it defaults to the "Publish to Azure" Profile so I can't actually publish it.
Thanks!

@tonyanziano tonyanziano transferred this issue from microsoft/BotFramework-Composer-Nightlies Dec 21, 2020
@tonyanziano
Copy link
Contributor

Hi @DS2019 ,

I've transferred this issue to the official Composer repository as we do not track issues on the nightly repository.

Sorry to hear you are still having trouble publishing. This sounds like a UI bug so we will take a look and update the ticket.

@luhan2017 any ideas off the top of your head? Or maybe Wenyi has thoughts on this? (I don't know wenyi's github username)

@tonyanziano
Copy link
Contributor

If you press "Ctrl + Shift + I" to open the Developer Tools and try selecting the PVA publish profile again, do you see any errors in the console?

@DS2019
Copy link
Author

DS2019 commented Dec 21, 2020

I don't think so. I choose "Publish to PVA" and it defaults right back to the Azure Profile:
BacktoAzure

@DS2019
Copy link
Author

DS2019 commented Dec 21, 2020

Oops, I missed this:
NotValid

@tonyanziano
Copy link
Contributor

Awesome, this is very helpful. Let me take a look at the code. I might have an idea of what's going on.

@tonyanziano tonyanziano reopened this Dec 21, 2020
@tonyanziano tonyanziano added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Dec 21, 2020
@tonyanziano
Copy link
Contributor

Found the issue. There was a recent PR #4924 that changed the publish extension history API and broke the PVA extension's ability to gather publish history. This causes it to error out which prevents you from selecting it as a publishing target.

I will have a fix out for this today.

@tonyanziano tonyanziano added the customer-replied-to Required for internal reporting. Do not delete. label Dec 21, 2020
@tonyanziano tonyanziano self-assigned this Dec 21, 2020
@DS2019
Copy link
Author

DS2019 commented Dec 30, 2020

Hi @tonyanziano - I've tried a few of the nightly versions, the latest being: da63bc9 and I still have the UI bug for Publishing to PVA:
FailPublish

@tonyanziano
Copy link
Contributor

tonyanziano commented Dec 30, 2020

Hey @DS2019 ,

Thanks for the reminder! This is totally my bad. My PR got approved yesterday for the fix and I didn't see it. So it still hasn't made it into the nightly builds. I will merge it in the next hour and I'll kick off a nightly build for you.

@DS2019
Copy link
Author

DS2019 commented Dec 30, 2020

@tonyanziano - sweet! Appreciate it!

@tonyanziano
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Publish Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. Team: Runtime & Publishing Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants