Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to login to Azure account for provisioning and publishing #3384

Closed
7 tasks
benbrown opened this issue Jun 11, 2020 · 0 comments · Fixed by #4221
Closed
7 tasks

Add ability to login to Azure account for provisioning and publishing #3384

benbrown opened this issue Jun 11, 2020 · 0 comments · Fixed by #4221
Assignees
Labels
Area: Publish feature-request A request for new functionality or an enhancement to an existing one. P0 Must Fix. Release-blocker Team: Runtime & Publishing

Comments

@benbrown
Copy link
Contributor

benbrown commented Jun 11, 2020

Add the ability to sign-in to an Azure account, thus making it possible to take actions on the user’s behalf such as creating and publishing to Azure resources.

A login to Azure will not be required to use Composer. It should continue to be possible to install an authentication plugin (such as AAD) to gate access to Composer and provide the user info context.

We should strive to implement this in a way that could be used by other plugins as well - for example, attaching a Github login to allow publish to Github. This will require some extensions to the current auth plugin system. Details here: #3390

Describe the solution you'd like

  • Get design input from @sangwoohaan and @mareekuh
  • Provide a login button that will allow the user to trigger the login process (needs design!)
  • If logged in, show some status indicator (username?) and a logout button (Needs design!)
  • Upon login, capture the Azure access token, refresh token, tenant id, and metadata necessary to request a new token when it expires
  • Automatically refresh the token if expired
  • Require an active Azure login when using the “publish to target” tool
  • Require an active Azure login when using the provisioning tool

Additional context

This will require us to be a “First party app” which is described here:
https://identitydocs.azurewebsites.net/static/aad/first_party_decision_guide.html
This is how we achieve the same functionality in Emulator.

@benbrown benbrown added Type: Enhancement Needs-triage A new issue that require triage labels Jun 11, 2020
@benbrown benbrown added the R10 Release 10 - August 17th, 2020 label Jun 11, 2020
@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Jun 18, 2020
@VanyLaw VanyLaw added R11 Release 11 - November 15th, 2020 and removed R10 Release 10 - August 17th, 2020 labels Aug 6, 2020
This was referenced Sep 16, 2020
@cwhitten cwhitten removed the R11 Release 11 - November 15th, 2020 label Oct 1, 2020
@gabog gabog added feature-request A request for new functionality or an enhancement to an existing one. and removed Type: Enhancement labels Oct 6, 2020
@cwhitten cwhitten added the P0 Must Fix. Release-blocker label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Publish feature-request A request for new functionality or an enhancement to an existing one. P0 Must Fix. Release-blocker Team: Runtime & Publishing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants