Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean out unused code in assetManager model #2835

Closed
benbrown opened this issue Apr 29, 2020 · 1 comment
Closed

Clean out unused code in assetManager model #2835

benbrown opened this issue Apr 29, 2020 · 1 comment
Assignees
@boydc2014
Labels
Type: Bug Something isn't working

Comments

@benbrown
Copy link
Contributor

There is some code in the assetManager model that overlaps with the eject function and is most likely not used anymore. We should clean this out and/or make sure it is in alignment with the way eject works.

In particular:

  • copyRuntimeTo()
  • runtimeTemplates[]
  • getProjectRuntime()
@benbrown benbrown added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Apr 29, 2020
@benbrown benbrown self-assigned this Apr 29, 2020
@boydc2014
Copy link
Contributor

Hey, @benbrown , i cleaned it in this #2805, my plan is to include your biolerplate also with plugin, make sense?

@boydc2014 boydc2014 assigned boydc2014 and unassigned benbrown Apr 30, 2020
@boydc2014 boydc2014 mentioned this issue May 5, 2020
Merged
4 tasks
@cwhitten cwhitten closed this as completed May 6, 2020
@a-b-r-o-w-n a-b-r-o-w-n removed the Needs-triage A new issue that require triage label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boydc2014 boydc2014

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@benbrown @cwhitten @a-b-r-o-w-n @boydc2014