Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LU publishing failed when contains pattern with perbuilt entity #2749

Closed
7 tasks
KayMKM opened this issue Apr 23, 2020 · 6 comments
Closed
7 tasks

LU publishing failed when contains pattern with perbuilt entity #2749

KayMKM opened this issue Apr 23, 2020 · 6 comments
Assignees
Labels
bf-cli P0 Must Fix. Release-blocker R9-RC skill-reported Type: Bug Something isn't working

Comments

@KayMKM
Copy link

KayMKM commented Apr 23, 2020

Describe the bug

LU publishing failed when contains patterns with perbuilt entity. E.g:

- (create|book|schedule) (a|an) (meeting|appointment|event) [with {personName}] (at|for|on) [{FromDate}] [{FromTime}]
@ prebuilt personName

The reason is the prebuilt entity will be removed when cross train.

Version

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Additional context

@KayMKM KayMKM added Type: Bug Something isn't working Needs-triage A new issue that require triage skill-reported labels Apr 23, 2020
@hibrenda hibrenda removed the Needs-triage A new issue that require triage label Apr 23, 2020
@hibrenda
Copy link
Contributor

Synced with Yue. This is the background.

  • pattern with prebuilt entity can work for a single dialog
  • But it will hit some errors during #_interruption publish

@boydc2014
Copy link
Contributor

One more simple repro case

@boydc2014
Copy link
Contributor

we can use regexPattern="{.*?}" probably to detect an entity in pattern

@feich-ms
Copy link
Contributor

feich-ms commented May 6, 2020

BF-CLI fix is here microsoft/botframework-cli#758. If we think this is P0 blocker of R9 release for composer, then BF-CLI should let above fix PR in. Otherwise, we can target R10. Any thoughts @boydc2014 @hibrenda

@boydc2014
Copy link
Contributor

BF-CLI fix is here microsoft/botframework-cli#758. If we think this is P0 blocker of R9 release for composer, then BF-CLI should let above fix PR in. Otherwise, we can target R10. Any thoughts @boydc2014 @hibrenda

I think we have chance to take that in CLI and cut a new RC.

@feich-ms
Copy link
Contributor

feich-ms commented May 7, 2020

BF-CLI fix is merged into 4.9 RC, please update the package in composer when next RC is online @lei9444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bf-cli P0 Must Fix. Release-blocker R9-RC skill-reported Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants