Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "open bot" feature to recognize legacy "custom runtime" projects #2472

Closed
2 tasks
benbrown opened this issue Apr 1, 2020 · 2 comments
Closed
2 tasks
Assignees
Labels
R9 Release 9 - May 15th, 2020

Comments

@benbrown
Copy link
Contributor

benbrown commented Apr 1, 2020

Previous versions of Composer would include the runtime code in every new project, resulting in a folder structure like "MyBot/proj.cs" and "MyBot/ComposerDialogs/Main.dialog"

Newer versions of Composer do not include runtime code, resulting in a much flatter structure.

We should update this behavior to recognize both as bot projects, and, in connection with the runtime settings page (#2470) automatically configure legacy projects to use their locally packaged runtime when testing

  • Detect both file structures as "bot projects" (do not require opening ComposerDialogs directly)
  • When a bot project contains a ComposerDialogs folder, if custom runtime settings are absent, automatically route user to the /settings/runtime page and pre-fill the location and start command with the known location of the runtime
@benbrown benbrown added Type: Enhancement Needs-triage A new issue that require triage labels Apr 1, 2020
@benbrown benbrown self-assigned this Apr 1, 2020
@cwhitten cwhitten added R9 Release 9 - May 15th, 2020 and removed Needs-triage A new issue that require triage labels Apr 2, 2020
@boydc2014
Copy link
Contributor

See #2470 (comment), this is somehow conflict with allow user to config path to runtime.

@benbrown
Copy link
Contributor Author

benbrown commented Apr 8, 2020

A different solution has superceded this.

@benbrown benbrown closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R9 Release 9 - May 15th, 2020
Projects
None yet
Development

No branches or pull requests

3 participants