Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update app to read/write $kind instead of $type #2301

Closed
a-b-r-o-w-n opened this issue Mar 18, 2020 · 5 comments · Fixed by #2302
Closed

update app to read/write $kind instead of $type #2301

a-b-r-o-w-n opened this issue Mar 18, 2020 · 5 comments · Fixed by #2302
Assignees
@a-b-r-o-w-n @yeze322
Labels
R9 Release 9 - May 15th, 2020 Type: Engineering

Comments

@a-b-r-o-w-n
Copy link
Contributor

In 4.8, the SDK has begun deprecating the $type in favor of $kind. Our app currently only knows about $type. We need to read & write $kind instead.
@a-b-r-o-w-n a-b-r-o-w-n self-assigned this Mar 18, 2020
@a-b-r-o-w-n a-b-r-o-w-n added the R9 Release 9 - May 15th, 2020 label Mar 18, 2020
@a-b-r-o-w-n a-b-r-o-w-n linked a pull request Mar 18, 2020 that will close this issue
fix: Change templates to use $type over $kind #2302
Merged
@cwhitten cwhitten mentioned this issue Mar 18, 2020
Merged
@yeze322
Copy link
Contributor

yeze322 commented Mar 20, 2020

Will a global replacement work? I guess so

@a-b-r-o-w-n
Copy link
Contributor Author

@yeze322 maybe to start, but I want to be more intentional about it to make sure we don't miss anything. I assigned you in hopes that you can take ownership of the visual editor changes. I am trying to wrap up the form work and then I can work on this so if you get started, just open a draft PR and I can commit directly to that.

@yeze322
Copy link
Contributor

yeze322 commented Mar 23, 2020

@a-b-r-o-w-n okay

@yeze322 yeze322 mentioned this issue Mar 23, 2020
Merged
@yeze322
Copy link
Contributor

yeze322 commented Mar 23, 2020 •
edited
Loading

visual editor changes ready in #2333 @a-b-r-o-w-n

@cwhitten
Copy link
Member

addressed via #2333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-b-r-o-w-n a-b-r-o-w-n

@yeze322 yeze322

Labels
R9 Release 9 - May 15th, 2020 Type: Engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Change templates to use $type over $kind microsoft/BotFramework-Composer
3 participants
@cwhitten @a-b-r-o-w-n @yeze322