Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-file copy of LU / LG resources #2207

Closed
7 tasks
yeze322 opened this issue Mar 10, 2020 · 3 comments · Fixed by #2236
Closed
7 tasks

Cross-file copy of LU / LG resources #2207

yeze322 opened this issue Mar 10, 2020 · 3 comments · Fixed by #2236
Assignees

Comments

@yeze322
Copy link
Contributor

yeze322 commented Mar 10, 2020

Describe the bug

If a user copies a SendActivity action to another dialog file, the LG content inside that action won't be copied along with the action.

We should also cover the copy behavior of LU resources.

Version

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Additional context

Follows #2199

@yeze322 yeze322 added the Needs-triage A new issue that require triage label Mar 10, 2020
@yeze322 yeze322 changed the title Cross-fie copy of LU / LG resources Cross-file copy of LU / LG resources Mar 10, 2020
@yeze322 yeze322 self-assigned this Mar 10, 2020
@hibrenda
Copy link
Contributor

As discussed with Ze and Dong, we plan to support shallow copy for LG & LU . we may need further discussion on how to handle the custom template editing. eg. only common.lg could be toggled into edit mode. so that all the referenced templates could only be defined in common.lg.
for other lg file, user can only get the list view in all up and could do inline editing in list view. This will solve the shallow copy for nested template reference. @cwhitten @sangwoohaan

@cwhitten
Copy link
Member

addressed via #2236

@yeze322
Copy link
Contributor Author

yeze322 commented Mar 13, 2020

As discussed with Ze and Dong, we plan to support shallow copy for LG & LU . we may need further discussion on how to handle the custom template editing. eg. only common.lg could be toggled into edit mode. so that all the referenced templates could only be defined in common.lg.
for other lg file, user can only get the list view in all up and could do inline editing in list view. This will solve the shallow copy for nested template reference. @cwhitten @sangwoohaan

Yes, I and Zhixiang came up with a same conclusion that a dialog's correlated lg file shouldn't contain any self-referenced templates. As you said, all the referenced templates should only be defined in common.lg.

The new copy-paste behavior of LG templates in Visual Editor is right based on this policy. I think @zhixzhan can follow up the LGEditor / all-up-view part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants
@cwhitten @yeze322 @hibrenda and others