Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Functional - Settings -Onboarding]: No action is performed on activating Onboarding 'Enabled' toggle button. #2101

Closed
ShellySoni opened this issue Feb 26, 2020 · 4 comments

Comments

@ShellySoni
Copy link

User Experience:
For keyboard users it is difficult to perform the task if any control does not perform its functionality.

Test Environment:
Environment: Chromium Edge (Anaheim) + Narrator
Build Version: 2004 (OS Build 19569.1000)​​
Microsoft Edge Version: 82.0.436.0 (Official build) canary (64-bit)​
Test URL: http://localhost:3000/home

Repro Steps:

  1. Open URL: http://localhost:3000/home
  2. "Bot Framework Composer" homepage will gets opened.
  3. Select any of the previously created bot from "Recent Bots" or create one from the available Bots under 'Examples' and activate it.
  4. Select 'Settings' from left navigation.
  5. Select 'Onboarding' button available under 'Configuration'.
  6. Observe the issue on activating Onboarding 'Enabled' toggle button.

Actual Result:
No action is performed on activating Onboarding 'Enabled' toggle button. As it is mentioned in text that 'Enabling Onboarding will restart the product tour' but no actioned is performed.

Expected Result:
Action should be performed on activating Onboarding 'Enabled' toggle button.

Attachment:

Functional_Settings_Onboarding.zip

@ShellySoni ShellySoni added the Needs-triage A new issue that require triage label Feb 26, 2020
@corinagum
Copy link
Contributor

I don't believe this scenario prompts a restart of the app. My understanding is that onboarding is re-enabled, and prompts will show up again on the UI. (when navigating to other parts of the app)

I believe this trigger should have an screenreader announcement saying it is enabled or disabled, but there is no need to cause a refresh.

Could a developer confirm the expected behavior here? :) In terms confirming visually the change, I'm not quite sure what the ideal solution would be.

Would it be beneficial to have a toast as a confirmation that the setting has changed? This would provide extra visual feedback, and provide a placeholder of the aria-live text for the screenreader to announce the change in state.

@beyackle
Copy link
Contributor

I'll take a stab at this - I see something that should be useful here, although I'll want a designer to take a look at it to confirm it works well and looks good.

@beyackle beyackle self-assigned this Mar 26, 2020
@beyackle
Copy link
Contributor

image

@ashish315
Copy link

As checked and verified on below environment, the issue is fixed now. So, we are closing the issue.
Test Environment
Browser: Microsoft Edge Dev {Version 83.0.467.0 (Official build) dev (64-bit)}
OS build: 2004 (19588.1000)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants