Update client code to receive and pass back a bot ID #1918

benbrown · 2020-01-29T21:28:55Z

The client code needs to be updated to manage the identify of the open bot project. Up to this point, that information was stored in the server, but responsibility will now move to the client code to enable multi-user scenarios.

Describe the solution you'd like

When a bot project is opened or created, capture the included bot id and make it easily available throughout the app
Amend the code for all actions that make API calls to the server to include the bot id as part of the payload (~ 15 endpoints)
Update client code to include bot ID in the routes such that /dialogs/main is now /bot/:ID:/dialogs/Main. This applies to all routes that refer to content from a bot project, including settings.
Ensure that, given a bot id in the url, the application is loads the appropriate content into the editor and provides the correct value to api calls
Handle errors resulting from an invalid bot id - redirect user to the home screen and/or the open bot dialog.

The text was updated successfully, but these errors were encountered:

Related to #1918 and #1917

benbrown · 2020-02-24T21:04:18Z

This is completed in #2023

…ject Should fix last remaining item in #1918

* first commit of working prototype for mongoDB storage * change mechanism for creating zip file for syncing to runtime now builds all the files loaded into project (from arbitrary source) rahter than zipping a folder on disk * clean up console output * plugin loader looks for plugins, finds them * dynamically load in the storage provider via plugin loader use custom storage if one is specified * remove some debug traces * clean up some minor code formatting things * disable linter rule to allow for requiring in plugin modules * slight refactor of plugin loader to encapsulate functionality add sample web route plugin first tiny stab at publish -- TIME TO BRANCH * functioning auth implementattion using passportjs * sample github auth * first round of changes for multi-user support Related to #1918 and #1917 * add in the bot project id into the route * fix new bot * fix save as * rationalize all the URLS used in context of a project * plumb user identity down through storage * disable plugins * add readme * plugin readme * plugin readme * plugin readme * plugin readme * import publisher controller from other branch * update to readme * import prototype of publishing page * updates * delete environment and connector * add error checking for missing project by id * Better error handling for attempts to write to a missing or moved project Should fix last remaining item in #1918 * add publish method with localpublish plugin * keep bot dir clean * basic publish of localpublish plugin * remove hostBot * add gitignore file * change unzip template into copy template folder * Fix build script * Fix default projectMap not exists * change luis operation to match local plugin * polish default setting * use projectId * clean up * remove lib dir * use projectId * use limit 'currentBotProjects' cache * remove unused * Update copy * return error response when publish failed * update name initialization process * fix some test,hide publish tab and change deploy script * fix UT integrity check * fix bf-cli version error * update the version * remove @microsoft/bf-cli-command@1.0.0 * try to fix todo e2e test * fix lint * fix lint * remove some unused test and skip some failed unit tests * feat: Prevent old content from overwriting newer changes (#2156) * updates to write operations to prevent overwrite not 100% working on LU files yet * debounce lu * remove comment * remove some console logs * address feedback from chris * remove commented code * change hint word deploy to publish * fix lint * fix some test syntax * update the ui for notification page * fix luis publish path not found * fix some e2e tests * fix onboarding when using projectId * fix notification page bug * Back out simple overwrite protection, will replace with less error prone mechanism * add plugins volumn in docker * fix docker up * fix unit test * fix the filesetting path * change docker to map multi ports. in order to support multi runtime * add projectId when create and delete dialog * fix botstatus * fix botstatus * remove console log * fix settings files path * update the moke data Co-authored-by: Wenyi Luo <wenyluo@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: zhixzhan <zhixzhan@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: leilzh <leilzh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

cwhitten · 2020-03-19T15:50:46Z

addressed via #2023

* first commit of working prototype for mongoDB storage * change mechanism for creating zip file for syncing to runtime now builds all the files loaded into project (from arbitrary source) rahter than zipping a folder on disk * clean up console output * plugin loader looks for plugins, finds them * dynamically load in the storage provider via plugin loader use custom storage if one is specified * remove some debug traces * clean up some minor code formatting things * disable linter rule to allow for requiring in plugin modules * slight refactor of plugin loader to encapsulate functionality add sample web route plugin first tiny stab at publish -- TIME TO BRANCH * functioning auth implementattion using passportjs * sample github auth * first round of changes for multi-user support Related to microsoft#1918 and microsoft#1917 * add in the bot project id into the route * fix new bot * fix save as * rationalize all the URLS used in context of a project * plumb user identity down through storage * disable plugins * add readme * plugin readme * plugin readme * plugin readme * plugin readme * import publisher controller from other branch * update to readme * import prototype of publishing page * updates * delete environment and connector * add error checking for missing project by id * Better error handling for attempts to write to a missing or moved project Should fix last remaining item in microsoft#1918 * add publish method with localpublish plugin * keep bot dir clean * basic publish of localpublish plugin * remove hostBot * add gitignore file * change unzip template into copy template folder * Fix build script * Fix default projectMap not exists * change luis operation to match local plugin * polish default setting * use projectId * clean up * remove lib dir * use projectId * use limit 'currentBotProjects' cache * remove unused * Update copy * return error response when publish failed * update name initialization process * fix some test,hide publish tab and change deploy script * fix UT integrity check * fix bf-cli version error * update the version * remove @microsoft/bf-cli-command@1.0.0 * try to fix todo e2e test * fix lint * fix lint * remove some unused test and skip some failed unit tests * feat: Prevent old content from overwriting newer changes (microsoft#2156) * updates to write operations to prevent overwrite not 100% working on LU files yet * debounce lu * remove comment * remove some console logs * address feedback from chris * remove commented code * change hint word deploy to publish * fix lint * fix some test syntax * update the ui for notification page * fix luis publish path not found * fix some e2e tests * fix onboarding when using projectId * fix notification page bug * Back out simple overwrite protection, will replace with less error prone mechanism * add plugins volumn in docker * fix docker up * fix unit test * fix the filesetting path * change docker to map multi ports. in order to support multi runtime * add projectId when create and delete dialog * fix botstatus * fix botstatus * remove console log * fix settings files path * update the moke data Co-authored-by: Wenyi Luo <wenyluo@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: zhixzhan <zhixzhan@microsoft.com> Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: leilzh <leilzh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>

benbrown added Type: Enhancement Needs-triage A new issue that require triage labels Jan 29, 2020

benbrown mentioned this issue Jan 29, 2020

Add support for multi-user features #1916

Closed

14 tasks

cwhitten removed the Needs-triage A new issue that require triage label Feb 1, 2020

benbrown added a commit that referenced this issue Feb 12, 2020

first round of changes for multi-user support

8e825c7

Related to #1918 and #1917

benbrown mentioned this issue Feb 19, 2020

feat: Plugin loader and multi-user capabilities #2023

Merged

14 tasks

hibrenda assigned benbrown Feb 25, 2020

benbrown added a commit that referenced this issue Feb 25, 2020

Better error handling for attempts to write to a missing or moved pro…

438a179

…ject Should fix last remaining item in #1918

hibrenda added the R9 Release 9 - May 15th, 2020 label Mar 16, 2020

cwhitten closed this as completed Mar 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update client code to receive and pass back a bot ID #1918

Update client code to receive and pass back a bot ID #1918

benbrown commented Jan 29, 2020 •

edited

Loading

benbrown commented Feb 24, 2020

cwhitten commented Mar 19, 2020

Update client code to receive and pass back a bot ID #1918

Update client code to receive and pass back a bot ID #1918

Comments

benbrown commented Jan 29, 2020 • edited Loading

Describe the solution you'd like

benbrown commented Feb 24, 2020

cwhitten commented Mar 19, 2020

benbrown commented Jan 29, 2020 •

edited

Loading