Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lu inline editor swallow characters #1748

Closed
2 of 7 tasks
lei9444 opened this issue Dec 10, 2019 · 4 comments
Closed
2 of 7 tasks

lu inline editor swallow characters #1748

lei9444 opened this issue Dec 10, 2019 · 4 comments
Assignees
Labels
R8 Release 8 - March 16th, 2020 Type: Bug Something isn't working

Comments

@lei9444
Copy link
Contributor

lei9444 commented Dec 10, 2019

Complete the necessary portions of this template and delete the rest.

Describe the bug

inline lu editor swallow characters if enter quickly.

Version

master branch

Browser

What browser are you using?

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

What operating system are you using?

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Give a clear and concise description of what you expected to happen.

Screenshots

1234

Additional context

Add any other context about the problem here.

@lei9444 lei9444 added the Needs-triage A new issue that require triage label Dec 10, 2019
@hibrenda hibrenda added Type: Bug Something isn't working and removed Needs-triage A new issue that require triage labels Dec 12, 2019
@hibrenda hibrenda added the R8 Release 8 - March 16th, 2020 label Dec 12, 2019
@zhixzhan
Copy link
Contributor

looks like unexpected re-render, i will take a look

@yeze322
Copy link
Contributor

yeze322 commented Dec 12, 2019

the solution should be controling the submission rate of that editor to avoid triggerring save api too frequent. form editor also ran into this problem.

to entirely solve this kind of issue, we should avoid resetting global state at each invocation of the save handler

@zhixzhan
Copy link
Contributor

zhixzhan commented Dec 12, 2019

the solution should be controling the submission rate of that editor to avoid triggerring save api too frequent. form editor also ran into this problem.

to entirely solve this kind of issue, we should avoid resetting global state at each invocation of the save handler

Sure it is, every form commit would case a global state change. For one component, if the value it referred changed, it would auto re-render it self. for most component, it works fine. But for some editing field, like monaco-editor, text-input, it cause lost forcus or blur cursor. My current solution here is maintain a local state, avoid re-render triggered by global state, not the best but works anyway.

Appends:
The key point here is if only change the value property, it could keep the editing component's state like focus, cursor.

@cwhitten
Copy link
Member

addressed in #1765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R8 Release 8 - March 16th, 2020 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants