Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linting & Validation] Error notification for inline lg should navigate to form instead of all up view #1742

Closed
a-b-r-o-w-n opened this issue Dec 9, 2019 · 3 comments
Assignees
Labels
R8 Release 8 - March 16th, 2020

Comments

@a-b-r-o-w-n
Copy link
Contributor

No description provided.

@a-b-r-o-w-n a-b-r-o-w-n added the Needs-triage A new issue that require triage label Dec 9, 2019
@cwhitten cwhitten added R8 Release 8 - March 16th, 2020 and removed Needs-triage A new issue that require triage labels Dec 10, 2019
@cwhitten
Copy link
Member

If there is an error in an .lg template, the notifications/linking heuristic should be:

  • if if the error is in an inline lg template, link to the form
  • if the error is a custom crafted lg template, link to the .lg file

@zhixzhan
Copy link
Contributor

zhixzhan commented Dec 13, 2019

If there is an error in an .lg template, the notifications/linking heuristic should be:

  • if if the error is in an inline lg template, link to the form

I think we can treat a template as an inline lg template if it's naming format is bfd[type]-[id]

  • if the error is a custom crafted lg template, link to the .lg file

By the way, because of our inline editing experience is based on template, can lgParser diagnostic provide a property indicate error belong to which template, or a template level diagnostic ? @Danieladu @boydc2014

if not we have to repeat write code like this in several place.

// filter diagnostics belong to this template.
      lgDiagnostics = checkText(text).filter(lgDialg => {
        return (
          lgDialg.range.start.line >= template.startLineNumber &&
          lgDialg.range.end.line <= template.endLineNumber
        );
      });

@cwhitten
Copy link
Member

cwhitten commented Feb 6, 2020

addressed via #1856

@cwhitten cwhitten closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R8 Release 8 - March 16th, 2020
Projects
None yet
Development

No branches or pull requests

5 participants