Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QnA Maker integration - Composer settings to written to appsettings.json #1538

Closed
2 of 7 tasks
stephanbisser opened this issue Nov 8, 2019 · 6 comments
Closed
2 of 7 tasks
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. P0 Must Fix. Release-blocker Type: Bug Something isn't working

Comments

@stephanbisser
Copy link

stephanbisser commented Nov 8, 2019

Whenever I add the QnA Maker KB details to the Composer's settings in the UI, those values are not written to the appsettings.json of my bot and therefore, the QnA Maker is not reachable and I get "Object not set to instance of an object" as a bot's reply in the emulator after trying to query QnA Maker.

However, if I insert the KBid, Key and Host directly into the "Connect to QnA Knowledgebase" in the dialog, this is working...

This is the content of my bot's appsettings.json after Restarting from Composer:

{
  "microsoftAppId": "",
  "bot": "ComposerDialogs",
  "cosmosDb": {
    "authKey": "",
    "collectionId": "botstate-collection",
    "cosmosDBEndpoint": "",
    "databaseId": "botstate-db"
  },
  "applicationInsights": {
    "InstrumentationKey": ""
  },
  "blobStorage": {
    "connectionString": "",
    "container": "transcripts"
  }
}

Version

Application SHA - test

Browser

What browser are you using?

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

What operating system are you using?

  • macOS
  • Windows
  • Ubuntu
@stephanbisser stephanbisser added the Needs-triage A new issue that require triage label Nov 8, 2019
@cwhitten cwhitten added Type: Bug Something isn't working and removed Needs-triage A new issue that require triage labels Nov 8, 2019
@cwhitten
Copy link
Member

cwhitten commented Nov 8, 2019

@stephanbisser are you connecting to the bot once you've deployed, or is the bot running locally?

@compulim compulim added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. labels Nov 8, 2019
@hibrenda hibrenda added the P0 Must Fix. Release-blocker label Nov 11, 2019
@hibrenda
Copy link
Contributor

QnA maker settings are correctly set into appsettings but the endpoint key does not handle correctly.

@VanyLaw
Copy link
Contributor

VanyLaw commented Nov 11, 2019

@hibrenda It's because the botproject(runtime) read qna.endpointkey from disk before. Now, we need to send this from composer server to botproject(runtime).

@stephanbisser
Copy link
Author

@cwhitten I connect to my local running bot as I have not deployed it yet...

@cwhitten
Copy link
Member

cwhitten commented Nov 13, 2019

Hi @stephanbisser, this should be addressed in the master branch via #1571

@stephanbisser
Copy link
Author

Thanks a lot @cwhitten working now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. P0 Must Fix. Release-blocker Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants