Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing naming of dialogs #1079

Closed
yochay opened this issue Oct 11, 2019 · 1 comment
Closed

Confusing naming of dialogs #1079

yochay opened this issue Oct 11, 2019 · 1 comment
Labels
P2 Nice to have UX Design Need UX Design

Comments

@yochay
Copy link
Contributor

yochay commented Oct 11, 2019

Describe the bug

user can change the name of dialog to anything they want and end up in a funky situation

image

The problem is that it is not clear what is the unique ID of a dialog and whether we care to restrict the user?

Expected behavior

Open for feedback.

@yochay yochay added the Needs-triage A new issue that require triage label Oct 11, 2019
@vishwacsena
Copy link
Contributor

@yochay what you have in the screenshot are triggers and at the moment there is no validation requiring that trigger names are unique. #778 is tracking default naming for things as well as what need to be unique. To keep things clear, we should disallow duplicate trigger names within a dialog. Of course the dialog names need to be unique since they correspond to a folder on disk.

@cwhitten cwhitten added P2 Nice to have Type: Enhancement UX Design Need UX Design and removed Needs-triage A new issue that require triage labels Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Nice to have UX Design Need UX Design
Projects
None yet
Development

No branches or pull requests

3 participants