fix: remove edit button in lu all up view (#2146)

* fix some known issues * fix e2e test * handle comments Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
microsoft · Mar 6, 2020 · c17b59e · c17b59e
1 parent 1bea213
commit c17b59e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/Composer/cypress/integration/LUPage.spec.ts b/Composer/cypress/integration/LUPage.spec.ts
@@ -14,10 +14,7 @@ context('LU Page', () => {
     cy.contains('ToDoBotWithLuisSample.Main');
     cy.contains('All');
 
-    cy.get('.toggleEditMode button').as('switchButton');
-
-    // all multiple file, edit mode button is disabled.
-    cy.get('@switchButton').should('be.disabled');
+    cy.get('.toggleEditMode button').should('not.exist');
 
     // by default is table view
     cy.findByTestId('LUEditor')
@@ -28,7 +25,7 @@ context('LU Page', () => {
     cy.findByTestId('LUEditor').within(() => {
       cy.findByText('__TestToDoBotWithLuisSample.Main').click();
     });
-
+    cy.get('.toggleEditMode button').as('switchButton');
     // goto edit-mode
     cy.get('@switchButton').click();
     cy.findByTestId('LUEditor')

diff --git a/Composer/packages/client/src/pages/language-understanding/index.tsx b/Composer/packages/client/src/pages/language-understanding/index.tsx
@@ -91,16 +91,17 @@ const LUPage: React.FC<LUPageProps> = props => {
       <div css={ContentHeaderStyle}>
         <div css={HeaderText}>{formatMessage('User Input')}</div>
         <div css={flexContent}>
-          <Toggle
-            className={'toggleEditMode'}
-            css={actionButton}
-            onText={formatMessage('Edit mode')}
-            offText={formatMessage('Edit mode')}
-            defaultChecked={false}
-            checked={!!edit}
-            disabled={isRoot && edit === false}
-            onChange={onToggleEditMode}
-          />
+          {(!isRoot || edit) && (
+            <Toggle
+              className={'toggleEditMode'}
+              css={actionButton}
+              onText={formatMessage('Edit mode')}
+              offText={formatMessage('Edit mode')}
+              defaultChecked={false}
+              checked={!!edit}
+              onChange={onToggleEditMode}
+            />
+          )}
         </div>
       </div>
       <div css={ContentStyle} data-testid="LUEditor">