chore: remove 'InitProperty' type in Composer (#2096)

* disable InitProperty entry * remove InitProperty definition
microsoft · Feb 26, 2020 · 9b4ed6d · 9b4ed6d
1 parent c1a3d51
commit 9b4ed6d
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 46 deletions.
diff --git a/Composer/packages/extensions/obiformeditor/demo/src/editorschema.json b/Composer/packages/extensions/obiformeditor/demo/src/editorschema.json
@@ -63,9 +63,6 @@
     "Microsoft.IfCondition": {
       "title": "Branch: If/Else"
     },
-    "Microsoft.InitProperty": {
-      "title": "Initialize Property"
-    },
     "Microsoft.OnIntent": {
       "title": "Intent"
     },

diff --git a/Composer/packages/extensions/visual-designer/demo/src/samples/todo/AddToDo.json b/Composer/packages/extensions/visual-designer/demo/src/samples/todo/AddToDo.json
@@ -49,7 +49,7 @@
             "condition": "user.todos == null",
             "actions": [
               {
-                "$type": "Microsoft.InitProperty",
+                "$type": "Microsoft.SetProperty",
                 "$designer": {
                   "createdAt": "2019-07-16T20:01:05.970Z",
                   "updatedAt": "2019-07-16T20:01:13.866Z",

diff --git a/Composer/packages/extensions/visual-designer/demo/src/stories/VisualSDKDemo.js b/Composer/packages/extensions/visual-designer/demo/src/stories/VisualSDKDemo.js
@@ -20,7 +20,6 @@ export class VisualSDKDemo extends Component {
     const initialTypes = [
       SDKTypes.SendActivity,
       SDKTypes.EditArray,
-      SDKTypes.InitProperty,
       SDKTypes.SetProperties,
       SDKTypes.SetProperty,
       SDKTypes.DeleteProperties,

diff --git a/Composer/packages/extensions/visual-designer/src/schema/uischema.tsx b/Composer/packages/extensions/visual-designer/src/schema/uischema.tsx
@@ -117,10 +117,6 @@ export const uiSchema: UISchema = {
     'ui:widget': ActionCard,
     content: data => `${data.changeType} {${data.itemsProperty || '?'}}`,
   },
-  [SDKTypes.InitProperty]: {
-    'ui:widget': ActionCard,
-    content: data => `{${data.property || '?'}} = new ${data.type || '?'}`,
-  },
   [SDKTypes.SetProperty]: {
     'ui:widget': ActionCard,
     content: data => `{${data.property || '?'}} = ${data.value || '?'}`,

diff --git a/Composer/packages/lib/shared/src/appschema.ts b/Composer/packages/lib/shared/src/appschema.ts
@@ -1400,11 +1400,6 @@ export const appschema: OBISchema = {
           description: 'Two-way branch the conversation flow based on a condition.',
           $ref: '#/definitions/Microsoft.IfCondition',
         },
-        {
-          title: 'Microsoft.InitProperty',
-          description: 'Define and initialize a property to be an array or object.',
-          $ref: '#/definitions/Microsoft.InitProperty',
-        },
         {
           title: 'Microsoft.LogAction',
           description:
@@ -1700,28 +1695,6 @@ export const appschema: OBISchema = {
         },
       },
     },
-    'Microsoft.InitProperty': {
-      $role: 'unionType(Microsoft.IDialog)',
-      title: 'Initialize property',
-      description: 'Define and initialize a property to be an array or object.',
-      type: 'object',
-      properties: {
-        ...$properties(SDKTypes.InitProperty),
-        property: {
-          $role: 'expression',
-          title: 'Property',
-          description: 'Property (named location to store information).',
-          examples: ['user.age'],
-          type: 'string',
-        },
-        type: {
-          type: 'string',
-          title: 'Type',
-          description: 'Type of value.',
-          enum: ['object', 'array'],
-        },
-      },
-    },
     'Microsoft.IpEntityRecognizer': {
       $role: 'unionType(Microsoft.EntityRecognizers)',
       title: 'Ip Entity Recognizer',

diff --git a/Composer/packages/lib/shared/src/labelMap.ts b/Composer/packages/lib/shared/src/labelMap.ts
@@ -91,9 +91,6 @@ export const ConceptLabels: { [key in ConceptLabelKey]?: LabelOverride } = {
   [SDKTypes.IfCondition]: {
     title: formatMessage('Branch: if/else'),
   },
-  [SDKTypes.InitProperty]: {
-    title: formatMessage('Initialize a property'),
-  },
   [SDKTypes.LanguagePolicy]: {
     title: formatMessage('LanguagePolicy'),
   },

diff --git a/Composer/packages/lib/shared/src/types/schema.ts b/Composer/packages/lib/shared/src/types/schema.ts
@@ -49,7 +49,6 @@ export enum SDKTypes {
   HashtagEntityRecognizer = 'Microsoft.HashtagEntityRecognizer',
   HttpRequest = 'Microsoft.HttpRequest',
   IfCondition = 'Microsoft.IfCondition',
-  InitProperty = 'Microsoft.InitProperty',
   IpEntityRecognizer = 'Microsoft.IpEntityRecognizer',
   LanguagePolicy = 'Microsoft.LanguagePolicy',
   LogAction = 'Microsoft.LogAction',

diff --git a/Composer/packages/lib/shared/src/viewUtils.ts b/Composer/packages/lib/shared/src/viewUtils.ts
@@ -69,7 +69,6 @@ export const dialogGroups: DialogGroupsMap = {
     types: [
       SDKTypes.SetProperty,
       SDKTypes.SetProperties,
-      SDKTypes.InitProperty,
       SDKTypes.DeleteProperty,
       SDKTypes.DeleteProperties,
       SDKTypes.EditArray,

diff --git a/Composer/packages/server/schemas/editor.schema b/Composer/packages/server/schemas/editor.schema
@@ -115,11 +115,6 @@
       "helpLink": "https://aka.ms/bfc-controlling-conversation-flow",
       "helpLinkText": "Learn more"
     },
-    "Microsoft.InitProperty": {
-      "title": "Initialize Property",
-      "helpLink": "https://aka.ms/bfc-using-memory",
-      "helpLinkText": "Learn more"
-    },
     "Microsoft.LanguagePolicy": {
       "title": "LanguagePolicy"
     },