Custom dimensions are truncated to the wrong limit

[OsvaldoRosado]

See report at: https://stackoverflow.com/questions/52973839/nodejs-application-insigths-string-property-suddenly-limited-to-1024

https://github.com/Microsoft/ApplicationInsights-node.js/blob/develop/Library/Util.ts#L13 sets the limit for custom dimension properties values to length 1024. However, the limit specified in the schema is 8192 (see https://github.com/Microsoft/ApplicationInsights-Home/blob/master/EndpointSpecs/Schemas/Bond/EventData.bond#L19)

[sean-mcmanus]

We hit this bug too after upgrading from 1.0.5 to 1.0.6 (microsoft/vscode-cpptools#2587).

[ramya-rao-a]

@OsvaldoRosado Can you post an update here when a new version is released?

[OsvaldoRosado]

@ramya-rao-a Will do

[ramya-rao-a]

@OsvaldoRosado What is the current plan for the next release?

Due to this issue, the C++ extension had to revert back to the older version which has the spawning powershell problem

So either we need to have a new version of the applicationInsights or the C++ extension will have to go back to an even older version of applicationInsights.

[OsvaldoRosado]

@ramya-rao-a My current intention is to wait for more changes before releasing a new version. There's some other recently found bugs that should get fixes in as well.

Because the variable that controls the limit here is a public static variable, this is easily worked around with code like the following:

const appInsightsUtil = require("applicationinsights/out/Library/Util")
appInsightsUtil.MAX_PROPERTY_LENGTH = 8192;

[ramya-rao-a]

Thanks @OsvaldoRosado

@sean-mcmanus also mentioned that he needs more time to release a new version due to major changes in the master branch. Therefore, the current plan is to point the C++ extension users to an older version of the extension.

Thanks for all the help on this.

[OsvaldoRosado]

Version 1.0.7 should be out now with the fix for this bug

[ramya-rao-a]

Thanks!